Add benchmarks for hashjoin candidate equality filtering - #23980
Merged
neilconway merged 1 commit intoJul 30, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23980 +/- ##
==========================================
- Coverage 80.75% 80.75% -0.01%
==========================================
Files 1096 1096
Lines 373582 373605 +23
Branches 373582 373605 +23
==========================================
+ Hits 301686 301699 +13
- Misses 53893 53897 +4
- Partials 18003 18009 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
shehab-ali
marked this pull request as ready for review
July 29, 2026 18:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Issue #23237 identifies hash join candidate equality filtering as a potential
performance bottleneck. Before changing that implementation, we need stable
benchmarks that reproduce the relevant workloads and let us measure the effect
of a proposed optimization independently.
The existing hash join benchmark suite covers high-fanout joins, but it does
not isolate these two cases:
string key.
multiple key columns.
This PR intentionally adds only the benchmarks. The implementation change for
equal_rows_arrwill be submitted separately so that the benchmark workloadscan be reviewed and established independently of the optimization.
What changes are included in this PR?
This PR adds two hash join benchmarks:
Q24: single-hot-bucket long string-key join
bucket.
count(*)so the benchmark emphasizes hash match and candidateequality processing without materializing and retaining the full joined
output.
Q25: skewed composite-key join
probe rows use one value.
join-key equality.
count(*)to focus the measurement on the join match path.Both benchmarks:
HashJoinExec.hjbenchmark runner with descriptive build/probemetadata.
optimization for High HashJoin probe latency under high fanout and key skew (Partitioned mode) #23237.
Are these changes tested?
No hash join implementation is changed by this PR.
Are there any user-facing changes?
No.