Add dfbench statistics command - #23975
Open
gabotechs wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23975 +/- ##
==========================================
- Coverage 80.75% 80.65% -0.10%
==========================================
Files 1096 1097 +1
Lines 373282 373847 +565
Branches 373282 373847 +565
==========================================
+ Hits 301440 301526 +86
- Misses 53869 54330 +461
- Partials 17973 17991 +18 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
gabotechs
force-pushed
the
gabotechs/add-q-error-stats-benchmarks
branch
3 times, most recently
from
July 29, 2026 13:21
9c7a3d3 to
6f2a30b
Compare
gabotechs
force-pushed
the
gabotechs/add-q-error-stats-benchmarks
branch
from
July 29, 2026 13:25
6f2a30b to
8b7b5ac
Compare
gabotechs
marked this pull request as ready for review
July 29, 2026 13:28
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Provide a repeatable way to measure how closely planning cardinality statistics match runtime output for benchmark query suites.
What changes are included in this PR?
dfbench statisticsaccepts any Parquet data directory and SQL file or directory, so it can be used with TPC-DS, TPC-H, or another compatible query suite. It:--compare.Example: verify a TPC-DS Q21 improvement
Compare against a baseline from
mainTPC-H works with its partitioned data layout as well:
Are these changes tested?
No unit tests were added: this is a reporting CLI over planner statistics and runtime metrics, exercised by the benchmark-suite smoke runs above.
If reviewers think this type of code needs to be covered by unit tests let me know.
Are there any user-facing changes?
No, this is just for extending the
dfbenchcommand with a newdfbench statisticssubcommand