feat: centralizing higher-order list lambda evaluation helpers - #23911
Open
saadtajwar wants to merge 8 commits into
Open
feat: centralizing higher-order list lambda evaluation helpers#23911saadtajwar wants to merge 8 commits into
saadtajwar wants to merge 8 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #23911 +/- ##
==========================================
+ Coverage 80.75% 80.76% +0.01%
==========================================
Files 1096 1096
Lines 373413 373634 +221
Branches 373413 373634 +221
==========================================
+ Hits 301537 301762 +225
+ Misses 53891 53885 -6
- Partials 17985 17987 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
saadtajwar
marked this pull request as ready for review
July 27, 2026 22:25
Contributor
Author
|
@kosiew - PR ready for review! Thanks in advance for your time! 🙌 |
6 tasks
kosiew
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
array_filter,array_any_match, andarray_firsteach implement their own version of the same higher-order list execution pattern:This PR introduces shared helpers that allow for one area where the shared logic lives
What changes are included in this PR?
Added a helper in
lambda_utilsthat abstracts shared fields (original list/flat values/evaluated result) and functionality (creating theBooleanArray, adjusting offsets forList/LargeList, extractinglist/lambdapairs, etc), and applying toarray_filter/array_first/array_any_matchAre these changes tested?
Yes
Are there any user-facing changes?
No - shared helpers added are only visible within in the crate, rest is just rewrites