fix: preserve global limit for multi-partition fetch - #23800
Draft
discord9 wants to merge 1 commit into
Draft
Conversation
Signed-off-by: discord9 <discord9@163.com>
discord9
force-pushed
the
fix/limit-pushdown-global-fetch
branch
from
July 28, 2026 10:09
1229760 to
4b30ece
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23800 +/- ##
==========================================
- Coverage 80.69% 80.69% -0.01%
==========================================
Files 1095 1095
Lines 372623 372671 +48
Branches 372623 372671 +48
==========================================
+ Hits 300695 300731 +36
- Misses 53979 53986 +7
- Partials 17949 17954 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
An operator-level fetch on a plan with multiple output partitions is applied to
each partition. It can reduce work, but it does not satisfy a global limit. The
LimitPushdown rule could conflate those scopes and remove the remaining global
enforcement, producing too many rows or composing global and local limits
incorrectly.
What changes are included in this PR?
None,PendingLocal,PendingGlobal, orEnforced(hint-only).them as global limits.
CoalescePartitionsExecorSortPreservingMergeExecboundarybefore a multi-partition global requirement is considered satisfied.
LocalLimitExecsemantics separate from theglobal fetch.
Are these changes tested?
Yes. Physical optimizer regression tests cover:
The complete
physical_optimizer::limit_pushdownintegration test module andworkspace clippy were run from the final PR head.
Are there any user-facing changes?
Yes. Queries using these physical plan shapes now preserve the requested global
LIMIT/OFFSET rather than returning too many rows or over-restricting results.
There are no public API changes.