Skip to content

feat: benchmark_runner, improve --list, optional DATA_DIR - #23354

Merged
alamb merged 5 commits into
apache:mainfrom
Omega359:benchmark_runner_v2
Jul 16, 2026
Merged

feat: benchmark_runner, improve --list, optional DATA_DIR#23354
alamb merged 5 commits into
apache:mainfrom
Omega359:benchmark_runner_v2

Conversation

@Omega359

@Omega359 Omega359 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

Code cleanup, usability improvements. Added --list argument, DATA_DIR should now be properly inferred to the expected default if it's not provided.

What changes are included in this PR?

benchmark tool update only.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

Omega359 added 2 commits July 6, 2026 18:18
…ferred if it's not provided, and moved some code back into benchmark_runner that is cli only.
@Omega359
Omega359 marked this pull request as ready for review July 7, 2026 02:36
@alamb

alamb commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

@Omega359 -- I am sorry I didn't see this one before. Please feel free to ping me when you have PRs ready to review. I will get on this one

@alamb alamb changed the title feat: benchmark_runner - added --list, optional DATA_DIR feat: benchmark_runner, improve --list, optional DATA_DIR Jul 16, 2026

@alamb alamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it out

cargo run --bin benchmark_runner -- --list
...
SQL benchmarks:
  clickbench               43 queries
  clickbench_extended      13 queries
  clickbench_sorted        1 query
  h2o                      27 queries
  hj                       23 queries
  imdb                     113 queries
  nlj                      17 queries
  predicate_eval           26 queries
  push_down_topk           5 queries
  smj                      24 queries
  sort_tpch                11 queries
  tpcds                    99 queries
  tpch                     22 queries
  wide_schema              4 queries

works great

Thank you @Omega359

@alamb
alamb enabled auto-merge July 16, 2026 18:34
@alamb
alamb added this pull request to the merge queue Jul 16, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.60947% with 77 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@95de385). Learn more about missing BASE report.

Files with missing lines Patch % Lines
benchmarks/src/bin/benchmark_runner.rs 89.64% 51 Missing and 14 partials ⚠️
benchmarks/src/sql_benchmark_runner.rs 75.00% 10 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #23354   +/-   ##
=======================================
  Coverage        ?   80.65%           
=======================================
  Files           ?     1086           
  Lines           ?   366155           
  Branches        ?   366155           
=======================================
  Hits            ?   295323           
  Misses          ?    53238           
  Partials        ?    17594           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Merged via the queue into apache:main with commit 1c6350a Jul 16, 2026
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants