feat: benchmark_runner, improve --list, optional DATA_DIR - #23354
Merged
Conversation
…ferred if it's not provided, and moved some code back into benchmark_runner that is cli only.
Omega359
marked this pull request as ready for review
July 7, 2026 02:36
Contributor
|
@Omega359 -- I am sorry I didn't see this one before. Please feel free to ping me when you have PRs ready to review. I will get on this one |
--list, optional DATA_DIR
alamb
approved these changes
Jul 16, 2026
alamb
left a comment
Contributor
There was a problem hiding this comment.
I tested it out
cargo run --bin benchmark_runner -- --list
...
SQL benchmarks:
clickbench 43 queries
clickbench_extended 13 queries
clickbench_sorted 1 query
h2o 27 queries
hj 23 queries
imdb 113 queries
nlj 17 queries
predicate_eval 26 queries
push_down_topk 5 queries
smj 24 queries
sort_tpch 11 queries
tpcds 99 queries
tpch 22 queries
wide_schema 4 queries
works great
Thank you @Omega359
alamb
enabled auto-merge
July 16, 2026 18:34
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23354 +/- ##
=======================================
Coverage ? 80.65%
=======================================
Files ? 1086
Lines ? 366155
Branches ? 366155
=======================================
Hits ? 295323
Misses ? 53238
Partials ? 17594 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Code cleanup, usability improvements. Added
--listargument, DATA_DIR should now be properly inferred to the expected default if it's not provided.What changes are included in this PR?
benchmark tool update only.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.