Coalesce single-column sort runs during spill - #23222
Closed
nathanb9 wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #23208.
Rationale for this change
Single-column primitive sorts can produce many small sorted runs before spilling, increasing merge fan-in and merge overhead.
What changes are included in this PR?
This enables in-memory run coalescing on the sort spill path for single primitive-column sorts, bounded by
sort_in_place_threshold_bytes. Multi-column and non-primitive sorts keep the existing behavior.Are these changes tested?
Existing focused sort tests pass:
test_in_mem_sort_coalesced_runstest_sort_spilltest_sort_spill_utf8_stringsAlso ran:
cargo fmt --allcargo clippy --all-targets --all-features -- -D warningsgit diff --check