fixed makefile which pinned old issue - #149
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the site build Makefile to stop pinning apache/infrastructure-actions to an old commit and instead track the repository’s main branch, addressing build breakages from stale dependencies (Issue #144).
Changes:
- Removed the hardcoded
COMMIT_HASHpin. - Updated the repo update target to fetch/checkout/pull
maininstead of a specific commit.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
hey @Jefffrey can you please take a look in this PR is this is the change you want ? |
Jefffrey
reviewed
Feb 9, 2026
Updated git commands to remove hard reset.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
Description
The infrastructure-actions repository is currently pinned to a specific commit in the Makefile due to a previously reported issue in apache/infrastructure-actions (#218). That issue has since been resolved, but the pinned commit remains outdated.
I attempted to build the local Docker image using the pinned commit hash and encountered URL-related failures, which further suggests that the commit is no longer reliable.
This change updates the Makefile to stop pinning to a fixed commit and instead track the latest
mainbranch of the infrastructure-actions repository. This ensures we automatically receive future fixes and reduces the risk of build failures caused by stale dependencies.Changes Made :
COMMIT_HASHcheckout-committarget to fetch and sync withorigin/mainfix issue : #144