chore: bump Spark 3.5 to 3.5.9 - #5181
Merged
Merged
Conversation
Rename dev/diffs/3.5.8.diff to 3.5.9.diff and regenerate it against the v3.5.9 tag, and point the build, CI workflows, and docs at 3.5.9.
mbutrovich
approved these changes
Jul 31, 2026
mbutrovich
left a comment
Contributor
There was a problem hiding this comment.
Approved pending CI, thanks @andygrove!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A — routine patch-version bump within the already-supported Spark 3.5 line.
Rationale for this change
Spark 3.5 support should track the latest Spark 3.5 patch release. Apache Spark
3.5.9 has been released (tag
v3.5.9), so this moves Comet's Spark 3.5 build,CI, and documentation from 3.5.8 to 3.5.9.
What changes are included in this PR?
<spark.version>in thespark-3.5Maven profile to 3.5.9. Spark 3.5.9makes no transitive dependency changes relative to 3.5.8 (
scala.version,parquet.version,slf4j.version,jetty.version,hadoop.versionandarrow.versionare all unchanged), so no other profile properties move.dev/diffs/3.5.8.difftodev/diffs/3.5.9.diffand regenerates itagainst the
v3.5.9tag. Three hunks needed manual reapplication:pom.xml— context drift only (ivy.versionbumped upstream).WriteDistributionAndOrderingSuite.scala— context drift only (upstreamadded
TransformExpressionto a neighbouring import).KeyGroupedPartitioningSuite.scala— context drift plus one real change:3.5.9 adds a new
collectAllShuffleshelper matching onShuffleExchangeExec. Under Comet the shuffle is aCometShuffleExchangeExec, so the new helper'sassert(allShuffles.nonEmpty)call sites would fail. It now matches
ShuffleExchangeLike, consistent withhow the existing
collectShuffleshelper is already patched.and updates
dev/ci/compute-changes.py'sspark_3_5path filter to the newdiff filename.
compatibility page, the Iceberg contributor guide, the
setup-spark-builderaction / reusable-workflow input descriptions, and the
pip install pyspark==examples in the PyArrow UDF test scripts.
How are these changes tested?
git apply --check dev/diffs/3.5.9.diffagainst a pristinev3.5.9checkoutpasses with no rejects or fuzz.
diff, and that its only content differences from 3.5.8 are the context lines
above plus the
collectAllShuffleschange.npx prettier --checkon the modified markdown.v3.5.9,applies the new diff, and runs the SQL test suites.