build: Enable Spark SQL tests for Spark 4.2 [will not merge until 4.2 is released]#4208
Draft
andygrove wants to merge 2 commits intoapache:mainfrom
Draft
build: Enable Spark SQL tests for Spark 4.2 [will not merge until 4.2 is released]#4208andygrove wants to merge 2 commits intoapache:mainfrom
andygrove wants to merge 2 commits intoapache:mainfrom
Conversation
Adds dev/diffs/4.2.0-preview4.diff so the Spark SQL test suite can run against Apache Spark 4.2.0-preview4 with Comet enabled, and wires the 4.2 profile into the spark_sql_test workflow matrix. The diff was seeded from 4.1.1.diff and reconciled against v4.2.0-preview4.
Inherited from 4.1.1.diff during reconciliation. The Spark build was trying to resolve comet-spark-spark4.1_2.13 instead of the 4.2 artifact, causing the sql_hive jobs to fail before any tests ran.
andygrove
changed the title
andygrove
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #4142.
Rationale for this change
The
spark-4.2Maven profile (added in #4119) only compiled main sources; the SQL test diff and CI matrix entry were not yet in place. This PR turns on the Spark SQL test workflow against Spark 4.2.0-preview4 so we can start iterating on the failures tracked in #4142.What changes are included in this PR?
dev/diffs/4.2.0-preview4.diff, seeded from4.1.1.diffand reconciled againstv4.2.0-preview4. Notable manual reconciliations versus 4.1.1:KeyGroupedPartitioningSuite: 4.2 already declarescollectAllShuffles/collectShufflesasprotectedand returningSeq[ShuffleExchangeLike], so only the Cometcasearms and imports are added.WholeStageCodegenSuite:BroadcastHashJoinExecgained a 9th constructor argument; theCometColumnarToRowExecmatch was rewritten to the new arity.SQLTestUtils,PartitionedTablePerfStatsSuite,WriteDistributionAndOrderingSuite,QueryExecutionSuite,JoinHintSuite,ParquetRowIndexSuite,ParquetTypeWideningSuite,DisableUnnecessaryBucketedScanSuite: import-only or class-extension reconciliations.{spark-short: '4.2', spark-full: '4.2.0-preview4', java: 17, scan-impl: 'auto'}to thespark_sql_test.ymlmatrix.spark-4.2profile inpom.xml.How are these changes tested?
dev/diffs/4.2.0-preview4.diffre-applies cleanly to a freshv4.2.0-preview4checkout with no rejects../mvnw -Prelease -Pspark-4.2 -DskipTests -Dmaven.test.skip=true installbuilds clean.