Skip to content

feat!: use PluginManager#163

Open
erisu wants to merge 1 commit into
masterfrom
feat/use-common-plugin-manager
Open

feat!: use PluginManager#163
erisu wants to merge 1 commit into
masterfrom
feat/use-common-plugin-manager

Conversation

@erisu

@erisu erisu commented Jul 10, 2026

Copy link
Copy Markdown
Member

Use Cordova-Common's PluginManager instead of Browser's custom logic

Description

  • Cleaned plugin add and remove APIs to use cordova-common PluginManager.
  • Updated handlers API signature to match other platforms.
  • PluginManager to handle writting the plugin module.
  • Updated Tests

Testing

npm t

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

* Cleaned plugin add and remove APIs to use cordova-common PluginManager.
* Updated handlers API signature to match other platforms.
* PluginManager to handle writting the plugin module.
* Updated Tests
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 59.91379% with 93 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.39%. Comparing base (febc52d) to head (e5cb8e5).

Files with missing lines Patch % Lines
lib/Api.js 7.69% 36 Missing ⚠️
lib/BrowserProject.js 62.96% 30 Missing ⚠️
lib/browser_handler.js 42.55% 27 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
+ Coverage   62.27%   69.39%   +7.12%     
==========================================
  Files           7        8       +1     
  Lines        1185     1049     -136     
==========================================
- Hits          738      728      -10     
+ Misses        447      321     -126     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants