Skip to content

chore: agent quality expectations#23579

Open
squakez wants to merge 1 commit into
apache:mainfrom
squakez:chore/agent_quality
Open

chore: agent quality expectations#23579
squakez wants to merge 1 commit into
apache:mainfrom
squakez:chore/agent_quality

Conversation

@squakez
Copy link
Copy Markdown
Contributor

@squakez squakez commented May 28, 2026

Description

Target

  • I checked that the commit is targeting the correct branch (Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

@github-actions
Copy link
Copy Markdown
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@github-actions github-actions Bot added the docs label May 28, 2026
@squakez
Copy link
Copy Markdown
Contributor Author

squakez commented May 28, 2026

@davsclaus this is after the conversation we had in last meeting. I hope it helps to increase the level of quality of contributions.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 28, 2026

ℹ️ CI did not run targeted module tests.


⚙️ View full build and test results

@davsclaus davsclaus requested review from orpiske and oscerd May 28, 2026 08:14
@orpiske
Copy link
Copy Markdown
Contributor

orpiske commented May 28, 2026

I think this is a good idea, but a bit too broad - as even SCAs can have a lot of false positives.

I would try to narrow this a bit, towards more specific and recurrent anti patterns.

@oscerd
Copy link
Copy Markdown
Contributor

oscerd commented May 28, 2026

I would rephrase this, because the quality could degrade if the agent follow this literally. Maybe we could try for a while and eventually rollback.

Copy link
Copy Markdown
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could try, but if we notice the quality decrease or weird things, we should revert.

@squakez squakez force-pushed the chore/agent_quality branch from b7bce84 to 8e9e2d3 Compare May 28, 2026 08:36
@squakez
Copy link
Copy Markdown
Contributor Author

squakez commented May 28, 2026

I've provided a more clear list of main quality metrics to take in account. In general, this is likely going to be a try/error approach as we need to fine tune based on the concrete output we'll be seeing coming out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants