fix(tracking): replace deprecated datetime.utcnow() in S3 time partition#783
Open
Ghraven wants to merge 1 commit into
Open
fix(tracking): replace deprecated datetime.utcnow() in S3 time partition#783Ghraven wants to merge 1 commit into
Ghraven wants to merge 1 commit into
Conversation
_get_time_partition() used datetime.datetime.utcnow(), which is deprecated in Python 3.12+ and returns a naive datetime. Switched to datetime.now(timezone.utc).replace(tzinfo=None), which is timezone-aware at the source and produces a byte-identical isoformat() string (no +00:00 suffix), so the existing S3 prefix slicing is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
S3TrackingClient._get_time_partition()inburr/tracking/s3client.pybuilds the S3 path partition usingdatetime.datetime.utcnow():Why it matters
datetime.utcnow()is deprecated as of Python 3.12 (emitsDeprecationWarning) and returns a naive datetime, which is a common source of timezone bugs.Fix
This is timezone-aware at the source (correct UTC) and then drops tzinfo so that
.isoformat()produces a byte-identical string to the old call:Using
now(utc).isoformat()directly would have appended+00:00and broken thetime[14:]slice, so.replace(tzinfo=None)is intentional to preserve the existing partition format exactly.Verification
Confirmed the two formats are identical in shape (no offset suffix), so the resulting S3 prefixes (
year/month/day/hour/...) are unchanged. File parses and imports. Happy to adjust if you would prefer keeping the offset or a different partition scheme.