Skip to content

MINOR: [CI][C++] Fix Docker caching on JNI builds - #50742

Open
pitrou wants to merge 1 commit into
apache:mainfrom
pitrou:jni-caching
Open

MINOR: [CI][C++] Fix Docker caching on JNI builds#50742
pitrou wants to merge 1 commit into
apache:mainfrom
pitrou:jni-caching

Conversation

@pitrou

@pitrou pitrou commented Jul 30, 2026

Copy link
Copy Markdown
Member

Rationale for this change

Docker caching didn't work on JNI builds as the Docker volume storage didn't match the cached directory.

What changes are included in this PR?

Move the DOCKER_VOLUME_PREFIX definition at the C++ Extra workflow top level so that it also affects Docker-based JNI jobs.

Are these changes tested?

Yes, by existing CI runs.

Before:

After:

Are there any user-facing changes?

No.

@pitrou pitrou added the CI: Extra: C++ Run extra C++ CI label Jul 30, 2026
@github-actions github-actions Bot added the awaiting review Awaiting review label Jul 30, 2026
@github-actions

Copy link
Copy Markdown

Thanks for opening a pull request!

This pull request has been automatically converted to a draft because its title doesn't match Arrow's required format.

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

After updating the title, you can mark the pull request as ready for review.

See also:

@pitrou pitrou changed the title EXP: [CI][C++] Fix Docker caching on JNI builds MINOR: [CI][C++] Fix Docker caching on JNI builds Jul 30, 2026
@pitrou
pitrou marked this pull request as ready for review July 30, 2026 15:29
@pitrou

pitrou commented Jul 30, 2026

Copy link
Copy Markdown
Member Author

@kou Is this ok?

Note that the builds themselves will be fixed by #50741

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Comment on lines 489 to 491
ARCHERY_DEBUG: 1
ARROW_ENABLE_TIMING_TESTS: OFF
DOCKER_VOLUME_PREFIX: ".docker/"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove them?

@github-actions github-actions Bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Aug 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting merge Awaiting merge CI: Extra: C++ Run extra C++ CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants