Skip to content

EXP: [C++] Make simdjson a runtime dependency #50736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pitrou wants to merge 2 commits into from
+2 −4
Closed

EXP: [C++] Make simdjson a runtime dependency #50736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5704034
EXP: [C++] Make simdjson a runtime dependency
pitrou Jul 30, 2026
46c1d4d
Remove IS_RUNTIME_DEPENDENCY=FALSE
pitrou Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions cpp/cmake_modules/ThirdpartyToolchain.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2851,9 +2851,7 @@ if(ARROW_WITH_SIMDJSON)
FORCE_ANY_NEWER_VERSION
TRUE
REQUIRED_VERSION
${ARROW_SIMDJSON_REQUIRED_VERSION}
IS_RUNTIME_DEPENDENCY
FALSE)
${ARROW_SIMDJSON_REQUIRED_VERSION})
if(SIMDJSON_VENDORED)
add_library(arrow::simdjson ALIAS simdjson)
else()
Expand Down
2 changes: 1 addition & 1 deletion cpp/src/arrow/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1045,7 +1045,7 @@ if(ARROW_JSON)
json/parser.cc
json/reader.cc)
foreach(ARROW_JSON_TARGET ${ARROW_JSON_TARGETS})
target_link_libraries(${ARROW_JSON_TARGET} PRIVATE RapidJSON arrow::simdjson)
target_link_libraries(${ARROW_JSON_TARGET} PRIVATE RapidJSON simdjson::simdjson)
endforeach()
else()
set(ARROW_JSON_TARGET_SHARED)
Expand Down
Loading