Skip to content

GH-50718: [C++][CI] Fix valgrind use of uninitialised value on FixedSizeListTestCase - #50721

Merged
pitrou merged 1 commit into
apache:mainfrom
HuaHuaY:fix_issue_50718
Jul 29, 2026
Merged

GH-50718: [C++][CI] Fix valgrind use of uninitialised value on FixedSizeListTestCase#50721
pitrou merged 1 commit into
apache:mainfrom
HuaHuaY:fix_issue_50718

Conversation

@HuaHuaY

@HuaHuaY HuaHuaY commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Rationale for this change

Fix a valgrind error.

What changes are included in this PR?

Add PrintTo method to FixedSizeListTestCase.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@HuaHuaY
HuaHuaY requested review from pitrou and wgtmac as code owners July 29, 2026 17:09
@github-actions github-actions Bot added the awaiting review Awaiting review label Jul 29, 2026
@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #50718 has been automatically assigned in GitHub to PR creator.

@pitrou

pitrou commented Jul 29, 2026

Copy link
Copy Markdown
Member

@github-actions crossbow submit conda-cpp-valgrind

@github-actions

Copy link
Copy Markdown
Unable to match any tasks for `conda-cpp-valgrind`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/30478162585

@pitrou

pitrou commented Jul 29, 2026

Copy link
Copy Markdown
Member

@github-actions crossbow submit valgrind

@github-actions

Copy link
Copy Markdown

Revision: 2cadd60

Submitted crossbow builds: ursacomputing/crossbow @ actions-b51c801bad

Task Status
test-conda-cpp-valgrind GitHub Actions
test-r-linux-valgrind GitHub Actions

@pitrou

pitrou commented Jul 29, 2026

Copy link
Copy Markdown
Member

Looking good, thank you @HuaHuaY !

@pitrou
pitrou merged commit 7dbcb0f into apache:main Jul 29, 2026
50 of 55 checks passed
@pitrou pitrou removed the awaiting review Awaiting review label Jul 29, 2026
@HuaHuaY
HuaHuaY deleted the fix_issue_50718 branch July 30, 2026 02:50
@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 7dbcb0f.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants