GH-50578: [C++][FlightRPC][ODBC] Always return SQL_NO_DATA from GetMoreResults

[amoeba]

Rationale for this change

Fixes a bug in the implementation of ODBC GetMoreResults in the FlightSQL ODBC driver. According to https://learn.microsoft.com/en-us/sql/odbc/reference/appendixes/statement-transitions?view=sql-server-ver17#sqlmoreresults, we should return SQL_NO_DATA for some states we previously were throwing another error in. This appears to be exposed by a behavior of only the Windows ODBC driver manager: GetMoreResults always gets called even for metadata queries.

What changes are included in this PR?

• Changed implementation and test: GetMoreResults now always returns SQL_NO_DATA.

Are these changes tested?

Yes, in CI.

Are there any user-facing changes?

No.

• GitHub Issue: [Flight SQL ODBC] HY010 Function sequence error during schema discovery using ExecuteReader(CommandBehavior.SchemaOnly) #50578

[github-actions]

⚠️ GitHub issue #50578 has no components, please add labels for components.

[alinaliBQ]

The CI hasn't run the C++ Extra tests, so I'm not sure whether TestSQLMoreResultsWithoutQuery will fail. If the driver manager doesn't return HY010 for SQLMoreResults, you may need to update TestSQLMoreResultsWithoutQuery to expect SQL_NO_DATA on all platforms.

arrow/cpp/src/arrow/flight/sql/odbc/tests/statement_test.cc

Lines 1986 to 1995 in deed9c0

	TYPED_TEST(StatementTest, TestSQLMoreResultsWithoutQuery) {
	#ifdef __linux__
	ASSERT_EQ(SQL_NO_DATA, SQLMoreResults(this->stmt));
	#else // Windows & Mac
	// Verify function sequence error state is reported when SQLMoreResults is called
	// without executing any queries
	ASSERT_EQ(SQL_ERROR, SQLMoreResults(this->stmt));
	VerifyOdbcErrorState(SQL_HANDLE_STMT, this->stmt, kErrorStateHY010);
	#endif
	}

to:

TYPED_TEST(StatementTest, TestSQLMoreResultsWithoutQuery) {
  ASSERT_EQ(SQL_NO_DATA, SQLMoreResults(this->stmt));
}

edit: fixed typo

[amoeba]

Good catch. I pushed without the test fix to verify the test fails in CI since I don't have the tests running locally.

[amoeba]

Failed successfully in https://github.com/apache/arrow/actions/runs/30479028112/job/90668568584?pr=50700#step:15:2559. Should pass with b1399a3.

[github-actions]

⚠️ GitHub issue #50578 has no components, please add labels for components.

[amoeba]

CI failures all look unrelated, the ODBC tests all pass so I think that's enough for this PR. This is ready for a review.

[alinaliBQ]

+1, LGTM