GH-50674: [Release] Add support for recovering Yum repositories - #50681
Conversation
|
|
raulcd
left a comment
There was a problem hiding this comment.
LGTM, don't think we've documented the binary-recover.sh script anywhere and this is a great tool, we should probably add a note somewhere in the developers documentation to point that this exist. We can do in a follow up task as this tool already exists so its an existing thing. Thanks @kou for working on this
|
Good point. I've added a note about this tool. |
|
I am merging, the failure on the docs job is unrelated and the change to the docs is minimal, it can be merge. If by any dark magic this change on the docs would produce a documentation failure, I'd own it and fix it :) |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 0cac818. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
We need this when we break our Yum repositories.
What changes are included in this PR?
We can recover Yum repositories too by
dev/release/binary-recover.sh.Are these changes tested?
Yes. I recovered our Yum repositories with this.
Are there any user-facing changes?
No.