GH-50678: [C++][Parquet] Remove unused member null_slot_usage in struct LevelInfo - #50679
Conversation
|
|
| if (output->null_count > 0 && level_info.null_slot_usage > 1) { | ||
| throw ParquetException( | ||
| "Null values with null_slot_usage > 1 not supported." | ||
| "(i.e. FixedSizeLists with null values are not supported)"); | ||
| } |
There was a problem hiding this comment.
Are we ok removing this? Is it handled elsewhere?
There was a problem hiding this comment.
In the current code, null_slot_usage is not assigned a value, so it will never be greater than 1.
|
I forgot I had written this comment #48587 (comment). Some CI compilers will reject the |
github-actions
Bot
added
awaiting committer review
|
CI failures are unrelated. Thank you @HuaHuaY ! |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 6f6051b. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
2 participants
Rationale for this change
Remove unused member
null_slot_usagein structLevelInfowhich is in theparquet::internalnamespace.What changes are included in this PR?
Remove member
null_slot_usagein structLevelInfo.Are these changes tested?
Yes.
Are there any user-facing changes?
No.
null_slot_usagein structLevelInfo#50678