GH-50601: [C++] Refactor TranslateTo for clearer semantics - #50602
Merged
Conversation
|
|
pitrou
changed the title
github-actions
Bot
added
awaiting committer review
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 0973268. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Follow-up to #50247
GenericNullLikePartition::TranslateTotranslates a partition result from a source range to a target range. This includes pointer arithmetic and does not allow bounds checking for the source and target range, as only the range starts are given. Ideally, we want to pass the entire source and target range to the function, which will allow us to both validate sizes, guarantee that the correct source range is passed, and the resultingGenericNullLikePartitionwill point into the target range.What changes are included in this PR?
Additional refactor for
GenericNullLikePartition::TranslateTo, that now allows moreDCHECKs. Each caller already had astd::spanobject for both source and target, which is now passed in directly.Are these changes tested?
Re-ran existing test-suite.
Are there any user-facing changes?
No.
GenericNullLikePartition::TranslateTo#50601