GH-50282: [C++][FlightRPC] Refactor GRPC server and transport classes - #50407
GH-50282: [C++][FlightRPC] Refactor GRPC server and transport classes#50407Alex-PLACET wants to merge 10 commits into
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
Alex-PLACET
changed the title
|
|
|
@raulcd Can you launch the CI please |
|
@raulcd Can you run the CI again please? |
|
@raulcd Can you launch the CI please |
|
@raulcd Can you launch the CI please (I hope it will be the last time) |
Sorry @Alex-PLACET , I missed this comment. Just kicked it |
f3c0c73 to
560bd8d
Compare
560bd8d to
20c2325
Compare
| Protobuf_SOURCE=BUNDLED \ | ||
| gRPC_SOURCE=BUNDLED \ |
There was a problem hiding this comment.
We should probably bump ARROW_GRPC_REQUIRED_VERSION. I am pretty sure if Ubuntu 22.04 ships older GRPC than necessary, we will also have to update the Linux Package jobs (.deb) for old ubuntu (potentially also for old Red Hat?), I'll kick off Linux Packages.
There was a problem hiding this comment.
maybe the label doesn't work well with draft, PRs, I am unsure why the Linux Package jobs did not trigger, I'll take a look.
| ::grpc::ByteBuffer* buffer, arrow::flight::internal::FlightData* out); | ||
|
|
||
| ARROW_FLIGHT_EXPORT | ||
| bool IsRegisteredGrpcFlightDataMessage( |
There was a problem hiding this comment.
we should add some comments on why now we have to register/unregister FlightData messages. Are those necessary?
github-actions
Bot
added
awaiting changes
2 participants
Uh oh!
There was an error while loading. Please reload this page.