Skip to content

GH-20403: [Doc] pyarrow.Array.diff Examples is wrongly rendered - #50096

Merged
AlenkaF merged 1 commit into
apache:mainfrom
thisisnic:GH-20403-pyarrow-array-diff-doc
Jun 4, 2026
Merged

GH-20403: [Doc] pyarrow.Array.diff Examples is wrongly rendered#50096
AlenkaF merged 1 commit into
apache:mainfrom
thisisnic:GH-20403-pyarrow-array-diff-doc

Conversation

@thisisnic

@thisisnic thisisnic commented Jun 4, 2026

Copy link
Copy Markdown
Member

Rationale for this change

Docs render weirdly

What changes are included in this PR?

Fix extra blank line breaking docs block

Are these changes tested?

I'll render docs

Are there any user-facing changes?

No

Copilot AI review requested due to automatic review settings June 4, 2026 09:29
@thisisnic
thisisnic requested review from AlenkaF, raulcd and rok as code owners June 4, 2026 09:29
@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown

⚠️ GitHub issue #20403 has been automatically assigned in GitHub to PR creator.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a docstring rendering issue in the pyarrow.Array.diff examples by removing an extra blank line that was breaking the example block formatting in the generated documentation.

Changes:

  • Removed an unintended blank line in the Array.diff docstring example output to prevent doc rendering issues.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@thisisnic

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit preview-docs

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown

Revision: ffcbd44

Submitted crossbow builds: ursacomputing/crossbow @ actions-6f8f500e27

Task Status
preview-docs GitHub Actions

@thisisnic

Copy link
Copy Markdown
Member Author

Before (view here):

image

After (view here):

image

@AlenkaF AlenkaF left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AlenkaF
AlenkaF merged commit cb7383c into apache:main Jun 4, 2026
18 checks passed
@AlenkaF AlenkaF removed the awaiting committer review Awaiting committer review label Jun 4, 2026
rok pushed a commit to rok/arrow that referenced this pull request Jun 4, 2026
…apache#50096)

Docs render weirdly

Fix extra blank line breaking docs block

I'll render docs

No
* GitHub Issue: apache#20403

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: AlenkaF <frim.alenka@gmail.com>
rok pushed a commit to rok/arrow that referenced this pull request Jun 4, 2026
…apache#50096)

Docs render weirdly

Fix extra blank line breaking docs block

I'll render docs

No
* GitHub Issue: apache#20403

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: AlenkaF <frim.alenka@gmail.com>
@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit cb7383c.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants