GH-50037: [Python] test_table_uses_memory_pool flaky on macOS 14 job - #50045
Conversation
|
|
|
Recent occurrence June 1st: https://github.com/apache/arrow/actions/runs/26750696954/job/78837634838#step:10:218 |
|
Root cause + deterministic repro Scanned the suite with Opus and found the "polluter" is Repro (disabling auto-GC just removes the rarity, mechanism is unchanged) python -m pytest -n0 -q -p nogc \
pyarrow/tests/parquet/test_dataset.py \
pyarrow/tests/test_pandas.py::test_table_uses_memory_pool-- FAILED ../pyarrow/tests/test_pandas.py::test_table_uses_memory_pool - assert 0 == 4736
1 failed, 56 passed, 6 skipped, 1 xfailed in 0.75sWith this PR fix (gc.collect() also before the baseline) makes baseline 0 and tests pass: |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit bfc9cdb. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
Fixes #50037
What changes are included in this PR?
Add
gc.collect()beforeprior_allocation = pa.total_allocated_bytes()intest_table_uses_memory_pooland also add to
_check_to_pandas_memory_unchangedhelper with the same pattern.Same fix as #44793
Are these changes tested?
Not reproduced locally yet.
Are there any user-facing changes?
No.