GH-49946: [Format] Better document equivalence between IPC file and streams - #49947
Conversation
3da85f2 to
6ea2485
Compare
|
@github-actions crossbow submit preview-docs |
|
Revision: 6ea2485 Submitted crossbow builds: ursacomputing/crossbow @ actions-0208c5a8f4
|
6ea2485 to
28765e5
Compare
|
@github-actions crossbow submit preview-docs |
|
Revision: 28765e5 Submitted crossbow builds: ursacomputing/crossbow @ actions-6cfd80b0e4
|
28765e5 to
51fb5a1
Compare
|
@github-actions crossbow submit preview-docs |
|
Revision: 51fb5a1 Submitted crossbow builds: ursacomputing/crossbow @ actions-3cd6e7c16a
|
paleolimbot
left a comment
There was a problem hiding this comment.
Thank you for writing this up!
| compliant writers SHOULD arrange the IPC File footer so that an IPC File can be | ||
| read using an IPC Stream reader with equivalent results. |
There was a problem hiding this comment.
It may be nice at some point to indicate in the "features" section of a flatbuffers Schema that the stream can definitely be read as an IPC stream (i.e., doesn't differ between what one would get from reading using the blocks in the footer). The fact that nanoarrow does this blindly is not great and I'll fix it, but it is a cool feature that you can do full scans without random access in most cases.
There was a problem hiding this comment.
What do you call the features section? Is it
Lines 71 to 81 in a0d2885
There was a problem hiding this comment.
That's what I was thinking of (but no need to deal with this now 🙂 )
51fb5a1 to
2f21cc8
Compare
|
I've reworded the equivalence section to also mention the Schema and custom metadata in the IPC file footer. Again @alamb @tustvold @CurtHagenlocher @zeroshade @jbonofre @lidavidm do you want to take a look? This is a (minor) spec update, I would rather find consensus on this. |
|
Also @joellubi |
|
@github-actions crossbow submit preview-docs |
|
Revision: 2f21cc8 Submitted crossbow builds: ursacomputing/crossbow @ actions-49a37905b6
|
CurtHagenlocher
left a comment
There was a problem hiding this comment.
Thanks! These improvements are great!
| The ``Buffer`` Flatbuffers value describes the location and size of a | ||
| piece of memory. Generally these are interpreted relative to the | ||
| **encapsulated message format** defined below. | ||
| buffer 0: field 0 ('col1') validity |
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 35eed28. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
As discussed in https://lists.apache.org/thread/jpxl3yzm96wkxzb1clokxklsy32b3plh, we want to better document the rough equivalence between IPC files and streams.
What changes are included in this PR?
Are these changes tested?
N/A.
Are there any user-facing changes?
No.