-
Notifications
You must be signed in to change notification settings - Fork 4.2k
GH-49103: [Python][Annotations] Add internal type system stubs (_types, error, _stubs_typing) #48622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
GH-49103: [Python][Annotations] Add internal type system stubs (_types, error, _stubs_typing) #48622
Changes from all commits
0bd8440
b865f34
37d87fb
43ff40f
07c1398
0acbc9d
83cab21
8e55077
eae20d1
789934a
7729137
ddd48c0
6f2a03a
ed2c72b
f0272fe
50077b6
94fcdf4
9701c2f
8982d1e
604b09b
3e9e864
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -136,11 +136,22 @@ repos: | |
| - id: flake8 | ||
| alias: python | ||
| name: Python Lint | ||
| additional_dependencies: | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. (Just for reference) This is what our
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will revisit seperately! |
||
| - flake8-pyi | ||
| args: | ||
| - "--config" | ||
| - "python/setup.cfg" | ||
| - "--extend-select" | ||
| - "Y" | ||
| - "--per-file-ignores" | ||
| - "python/pyarrow-stubs/pyarrow/*.pyi:E301,E302,E305,E701,F821" | ||
| files: >- | ||
| ^(c_glib|dev|python)/ | ||
| types: | ||
| - file | ||
| types_or: | ||
| - python | ||
| - pyi | ||
| exclude: >- | ||
| ( | ||
| ?^python/pyarrow/vendored/| | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,12 +15,6 @@ | |
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| """Type stubs for PyArrow. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just noting this file was added in #48618 |
||
|
|
||
| This is a placeholder stub file. | ||
| Complete type annotations will be added in subsequent PRs. | ||
| """ | ||
|
|
||
| from typing import Any | ||
|
|
||
| # TODO(GH-48970): remove __getattr__ before release as this | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,138 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| import datetime as dt | ||
|
|
||
| from _typeshed import ( | ||
| SupportsDunderGE, | ||
| SupportsDunderGT, | ||
| SupportsDunderLE, | ||
| SupportsDunderLT, | ||
| ) | ||
| from collections.abc import Collection, Container, Iterator, Sequence, Sized | ||
| from decimal import Decimal | ||
| from typing import Any, Literal, Protocol, TypeAlias, TypeVar | ||
| from typing_extensions import TypeAliasType | ||
|
|
||
| import numpy as np | ||
|
|
||
| from numpy.typing import NDArray | ||
|
|
||
| from pyarrow import lib | ||
| from pyarrow.lib import ChunkedArray | ||
|
|
||
| ArrayLike: TypeAlias = Any | ||
| ScalarLike: TypeAlias = Any | ||
| Order: TypeAlias = Literal["ascending", "descending"] | ||
| JoinType: TypeAlias = Literal[ | ||
| "left semi", | ||
| "right semi", | ||
| "left anti", | ||
| "right anti", | ||
| "inner", | ||
| "left outer", | ||
| "right outer", | ||
| "full outer", | ||
| ] | ||
| Compression: TypeAlias = Literal[ | ||
| "gzip", "bz2", "brotli", "lz4", "lz4_frame", "lz4_raw", "zstd", "snappy" | ||
| ] | ||
| NullEncoding: TypeAlias = Literal["mask", "encode"] | ||
| NullSelectionBehavior: TypeAlias = Literal["drop", "emit_null"] | ||
| TimeUnit: TypeAlias = Literal["s", "ms", "us", "ns"] | ||
|
|
||
| IntegerType: TypeAlias = ( | ||
| lib.Int8Type | ||
| | lib.Int16Type | ||
| | lib.Int32Type | ||
| | lib.Int64Type | ||
| | lib.UInt8Type | ||
| | lib.UInt16Type | ||
| | lib.UInt32Type | ||
| | lib.UInt64Type | ||
| ) | ||
| PyScalar: TypeAlias = ( | ||
| bool | ||
| | int | ||
| | float | ||
| | Decimal | ||
| | str | ||
| | bytes | ||
| | dt.date | ||
| | dt.datetime | ||
| | dt.time | ||
| | dt.timedelta | ||
| ) | ||
| NumpyScalar: TypeAlias = np.generic[Any] | ||
|
|
||
| _PyScalarT_co = TypeVar("_PyScalarT_co", bound=PyScalar, covariant=True) | ||
| _NumpyScalarT_co = TypeVar("_NumpyScalarT_co", bound=NumpyScalar, covariant=True) | ||
| _DataTypeT_co = TypeVar("_DataTypeT_co", bound=lib.DataType, covariant=True) | ||
| IntoArray = TypeAliasType( | ||
| "IntoArray", | ||
|
Comment on lines
+85
to
+86
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this "int to array" or "into array"? |
||
| Sequence[_PyScalarT_co | None] | ||
| | NDArray[_NumpyScalarT_co] | ||
| | lib.Array[lib.Scalar[_DataTypeT_co]] | ||
| | ChunkedArray[Any], | ||
| type_params=(_PyScalarT_co, _NumpyScalarT_co, _DataTypeT_co), | ||
| ) | ||
|
|
||
| Mask: TypeAlias = IntoArray[bool, np.bool_, lib.BoolType] | ||
| Indices: TypeAlias = IntoArray[int, np.integer[Any], IntegerType] | ||
|
|
||
| _T = TypeVar("_T") | ||
| _V = TypeVar("_V", covariant=True) | ||
|
|
||
| SingleOrList: TypeAlias = list[_T] | _T | ||
|
|
||
| class SupportsDunderEQ(Protocol): | ||
| def __eq__(self, other: object, /) -> bool: ... | ||
|
|
||
| FilterTuple: TypeAlias = ( | ||
| tuple[str, Literal["=", "==", "!="], SupportsDunderEQ] | ||
| | tuple[str, Literal["<"], SupportsDunderLT[Any]] | ||
| | tuple[str, Literal[">"], SupportsDunderGT[Any]] | ||
| | tuple[str, Literal["<="], SupportsDunderLE[Any]] | ||
| | tuple[str, Literal[">="], SupportsDunderGE[Any]] | ||
| | tuple[str, Literal["in", "not in"], Collection[Any]] | ||
| | tuple[str, str, Any] # Allow general str for operator to avoid type errors | ||
| ) | ||
|
|
||
| class Buffer(Protocol): ... | ||
| class SupportsPyBuffer(Protocol): ... | ||
|
|
||
| class SupportsArrowStream(Protocol): | ||
| def __arrow_c_stream__(self, requested_schema: Any = None, /) -> Any: ... | ||
|
|
||
| class SupportsPyArrowArray(Protocol): | ||
| def __arrow_array__(self, type: Any = None, /) -> Any: ... | ||
|
|
||
| class SupportsArrowArray(Protocol): | ||
| def __arrow_c_array__(self, requested_schema: Any = None, /) -> Any: ... | ||
|
|
||
| class SupportsArrowDeviceArray(Protocol): | ||
| def __arrow_c_device_array__( | ||
| self, requested_schema: Any = None, /, **kwargs: Any | ||
| ) -> Any: ... | ||
|
|
||
| class SupportsArrowSchema(Protocol): | ||
| def __arrow_c_schema__(self) -> Any: ... | ||
|
|
||
| class NullableCollection(Sized, Container[Any], Protocol[_V]): | ||
| def __iter__(self) -> Iterator[_V] | Iterator[_V | None]: ... | ||
| def __len__(self) -> int: ... | ||
| def __contains__(self, item: Any, /) -> bool: ... | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of scope, but would suggest we move to
ruffat some point. Faster, more frequent updates, and nicer maintainer.