generic channel support for FlightClient - #9933
Merged
Merged
Conversation
added 2 commits
May 6, 2026 16:05
github-actions
Bot
added
arrow
alamb
approved these changes
May 7, 2026
alamb
added
the
next-major-release
Contributor
Author
Thanks for the review! It is an API change but it is not a breaking API change. Everything should keep working as before |
Contributor
|
The MSRV failure is unrelated to this PR. For more details: |
Contributor
|
The CI failure is not due to your changes (your changes just triggered the rebuild) so I'll just merge this PR in and we can sort out any additional failures as a follow on PR |
Rich-T-kid
pushed a commit
to Rich-T-kid/arrow-rs
that referenced
this pull request
Jun 2, 2026
Allow FlightServiceClient to be parameterized over the underlying channel type, so users can wrap a tonic channel with custom interceptors or services. Motivation: Annotating outbound Flight requests with metadata (e.g. injecting OpenTelemetry trace context into headers) currently requires forking or wrapping at a higher level. Making the channel generic lets callers compose tower layers/interceptors idiomatically and propagate distributed tracing context without bespoke plumbing. --------- Co-authored-by: Rostislav Rumenov <rostislav.rumenov@qube-rt.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow FlightServiceClient to be parameterized over the underlying channel type, so
users can wrap a tonic channel with custom interceptors or services.
Motivation: Annotating outbound Flight requests with metadata (e.g. injecting
OpenTelemetry trace context into headers) currently requires forking or wrapping at
a higher level. Making the channel generic lets callers compose tower
layers/interceptors idiomatically and propagate distributed tracing context without
bespoke plumbing.