[56_maintenance] Prevent Rows row index overflow (#9817) - #9913
Merged
Conversation
11 tasks
- None. Rows used unchecked usize arithmetic when validating a requested row index. In optimized builds, very large indexes could wrap the bounds check before reaching the unchecked row access path. This adds checked arithmetic for row index validation and reuses it for both Rows::row and Rows::row_len. Yes. This adds regression coverage for overflowing row indexes. Invalid row indexes that overflow during bounds validation now panic consistently. There are no API changes.
alamb
marked this pull request as ready for review
May 5, 2026 20:30
Contributor
Author
A machine -- thank you for this |
Contributor
Ran out of gas last night 😅... I'll get to the rest today |
Contributor
Author
|
Thank you . I also asked for help from other commiters. Hopefully others can chip in too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
56.2.1(May 2026) #9857This PR:
56_maintenanceline