Minor: document why FixedSizeBinary offset is always 0 - #9861
Merged
Conversation
alamb
marked this pull request as ready for review
April 30, 2026 13:55
etseidl
approved these changes
Apr 30, 2026
Rich-T-kid
pushed a commit
to Rich-T-kid/arrow-rs
that referenced
this pull request
Jun 2, 2026
# Which issue does this PR close? - related to apache#9850 # Rationale for this change While working on apache#9850 I noticed that FixedSizeBinaryArray::offset always returns zero. This was confusing to me and so I wanted to document it for future readrs # What changes are included in this PR? Add some comments # Are these changes tested? By CI # Are there any user-facing changes? No, this is internal comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
FixedSizeBinaryArray::valueoffset truncation #9850Rationale for this change
While working on #9850 I noticed that FixedSizeBinaryArray::offset always returns zero.
This was confusing to me and so I wanted to document it for future readrs
What changes are included in this PR?
Add some comments
Are these changes tested?
By CI
Are there any user-facing changes?
No, this is internal comments