Remove deprecated legacy like kernels in arrow-string - #9674
Merged
Conversation
alamb
added
api-change
Contributor
|
All right, main is open for 59 so I took the liberty of merging this up from main to resolve a conflict |
Rich-T-kid
pushed a commit
to Rich-T-kid/arrow-rs
that referenced
this pull request
Jun 2, 2026
# Which issue does this PR close? - Closes apache#9675 # Rationale for this change The legacy kernels have been deprecated for 2 years and hidden from docs, and its just more code to build. # What changes are included in this PR? 1. Removing long deprecated legacy like kernels 2. Keeps all tests, just folded them into the existing pattern. This also increases the effective coverage - testing scalar comparison both for Utf8 scalars and Dict scalars # Are these changes tested? No functional changes, but refactors existing tests # Are there any user-facing changes? Only for users using long hidden and deprecated functions, but I this isn't a meaningfully public API. The functionality is also still available with very minor changes. Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
arrow-stringhas a lot of macro-generated deprecated kernels inlike.rs#9675Rationale for this change
The legacy kernels have been deprecated for 2 years and hidden from docs, and its just more code to build.
What changes are included in this PR?
Are these changes tested?
No functional changes, but refactors existing tests
Are there any user-facing changes?
Only for users using long hidden and deprecated functions, but I this isn't a meaningfully public API. The functionality is also still available with very minor changes.