Reduce Miri runtime even more - #9650
Merged
Merged
Conversation
Contributor
Author
|
The results are in! This change reduces the runtime for the miri CI job from ~100 minutes to 54. |
Jefffrey
approved these changes
Jun 3, 2026
Jefffrey
left a comment
Jefffrey
left a comment
Contributor
There was a problem hiding this comment.
we have precedent for ignoring some tests that take too long on miri, so makes sense to me
Co-authored-by: Jeffrey Vo <jeffrey.vo.australia@gmail.com>
Co-authored-by: Jeffrey Vo <jeffrey.vo.australia@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Follow up to #9629, as noted there miri runtime is dominated by the following 3 tests:
test_from_bitwise_binary_opsort::tests::fuzz_partition_validitysort::tests::test_fuzz_random_stringsWhat changes are included in this PR?
Under Miri, this PR reduces the amount of variations tested in 1, and ignores the latter two.
Are these changes tested?
They are tests!
Are there any user-facing changes?
No