Support nested REE in arrow-ord partition function - #9642
Merged
alamb merged 2 commits intoApr 3, 2026
Conversation
liamzwbao
marked this pull request as ready for review
April 1, 2026 01:56
alamb
approved these changes
Apr 1, 2026
alamb
left a comment
alamb
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me -- thank you @liamzwbao
I think it would be nice to move supports_distinct but we can do that as a follow on if you prefer
| /// `compare_op` unwraps at most one level of dictionary, then dispatches on | ||
| /// the leaf type. Anything else (REE, nested dictionary, nested/complex types) | ||
| /// must go through `make_comparator` instead. | ||
| fn supports_distinct(dt: &DataType) -> bool { |
Contributor
There was a problem hiding this comment.
this is a nice minimal code change 👍
| Ok(Partitions(Some(acc))) | ||
| } | ||
|
|
||
| /// Returns true if `distinct` (via `compare_op`) can handle this data type. |
Contributor
There was a problem hiding this comment.
I think this would make more sense to put next to distinct rather than in this module
So that owuld mean moving to arrow-ord/src/cmp.rs I think (and making it pub crate)
Contributor
Author
There was a problem hiding this comment.
Moved and added a UT
liamzwbao
force-pushed
the
issue-9640-support-nested-ree-partition
branch
from
April 3, 2026 01:05
422a88e to
e1e06b2
Compare
Contributor
|
Thanks again @liamzwbao |
Rich-T-kid
pushed a commit
to Rich-T-kid/arrow-rs
that referenced
this pull request
Jun 2, 2026
# Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. --> - Closes apache#9640. # Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> Although rare, it's totally valid to have nested REE and dict encoding and we should handle it correctly. # What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> Process nested REE, nested dict, dict of REE, REE of dict gracefully # Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> Yes # Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. If there are any breaking changes to public APIs, please call them out. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
partitionfunction #9640.Rationale for this change
Although rare, it's totally valid to have nested REE and dict encoding and we should handle it correctly.
What changes are included in this PR?
Process nested REE, nested dict, dict of REE, REE of dict gracefully
Are these changes tested?
Yes
Are there any user-facing changes?