Add List and ListView take benchmarks - #9626
Merged
Merged
Conversation
Dandandan
approved these changes
Apr 3, 2026
Contributor
|
Thanks @AdamGS |
alamb
pushed a commit
that referenced
this pull request
Apr 16, 2026
# Which issue does this PR close? - Closes #NNN. # Rationale for this change This PR builds on top of #9626, improving the results on those benchmarks. # What changes are included in this PR? 1. Similar to #9625, branch the function into the null and non-null paths 2. Copy the list elements in a single pass while building the offsets, allocating less intermediate state. # Are these changes tested? Added a few tests for sliced list arrays. # Are there any user-facing changes? No --------- Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Rich-T-kid
pushed a commit
to Rich-T-kid/arrow-rs
that referenced
this pull request
Jun 2, 2026
# Which issue does this PR close? - Closes apache#9627. # Rationale for this change Adding benchmarks makes it easier to measure performance and evaluate the impact of changes to the implementation. I also have a PR including some significant improvements, but figured its worth splitting it into two parts, LMK if its better to do that in one step. # What changes are included in this PR? Add a couple of utility functions to generate list and list_view arrays without providing a seed # Are these changes tested? Benchmarks run locally, same setup as other benchmarks. # Are there any user-facing changes? No
Rich-T-kid
pushed a commit
to Rich-T-kid/arrow-rs
that referenced
this pull request
Jun 2, 2026
# Which issue does this PR close? - Closes #NNN. # Rationale for this change This PR builds on top of apache#9626, improving the results on those benchmarks. # What changes are included in this PR? 1. Similar to apache#9625, branch the function into the null and non-null paths 2. Copy the list elements in a single pass while building the offsets, allocating less intermediate state. # Are these changes tested? Added a few tests for sliced list arrays. # Are there any user-facing changes? No --------- Signed-off-by: Adam Gutglick <adam@spiraldb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
takebenchmarks #9627.Rationale for this change
Adding benchmarks makes it easier to measure performance and evaluate the impact of changes to the implementation. I also have a PR including some significant improvements, but figured its worth splitting it into two parts, LMK if its better to do that in one step.
What changes are included in this PR?
Add a couple of utility functions to generate list and list_view arrays without providing a seed
Are these changes tested?
Benchmarks run locally, same setup as other benchmarks.
Are there any user-facing changes?
No