[bench] Replace pure-Rust snap with C++ snappy library for parquet (de)compression - #9528
Closed
Dandandan wants to merge 7 commits into
Closed
[bench] Replace pure-Rust snap with C++ snappy library for parquet (de)compression#9528Dandandan wants to merge 7 commits into
Dandandan wants to merge 7 commits into
Conversation
Use snappy_src (C++ snappy bindings) for raw snappy compress/decompress instead of the pure-Rust snap crate, while keeping snap as a dependency for CLI framed format support. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
run benchmark arrow_reader_clickbench |
|
🤖 |
Dandandan
changed the title
|
Benchmark script failed with exit code 101. Last 10 lines of output: Click to expand |
Dandandan
changed the title
Install g++ in CI setup-builder to provide libstdc++ needed by snappy_src. Move snappy_src to non-wasm32 target dependency and add pure-Rust snap fallback for wasm32 targets. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
run benchmark arrow_reader_clickbench |
|
🤖 |
|
Benchmark script failed with exit code 101. Last 10 lines of output: Click to expand |
Contributor
Author
|
run benchmark arrow_reader_clickbench CXXSTDLIB=c++ |
|
🤖 Hi @Dandandan, thanks for the request (#9528 (comment)).
Please choose one or more of these with You can also set environment variables on subsequent lines: Unsupported benchmarks: CXXSTDLIB=c++. |
Contributor
Author
|
run benchmark arrow_reader_clickbench |
|
🤖 |
|
Benchmark script failed with exit code 101. Last 10 lines of output: Click to expand |
18 tasks
Contributor
Author
|
run benchmark arrow_reader_clickbench |
|
🤖 |
|
Benchmark script failed with exit code 101. Last 10 lines of output: Click to expand |
Contributor
|
I will install libstdc++ on the runner |
Contributor
|
run benchmark arrow_reader_clickbench |
|
🤖 |
|
Benchmark script failed with exit code 101. Last 10 lines of output: Click to expand |
Contributor
Author
|
run benchmarks |
|
Benchmark job started for this request (job |
|
Benchmark for this request failed. Last 20 lines of output: Click to expand |
|
Benchmark for this request failed. Last 20 lines of output: Click to expand |
|
Benchmark for this request failed. Last 20 lines of output: Click to expand |
|
Benchmark for this request failed. Last 20 lines of output: Click to expand |
Removed link-cplusplus dependency from Cargo.toml.
Contributor
Author
|
run benchmark arrow_reader_clickbench |
|
🤖 Arrow criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing snappy_cpp (c07c455) to c194e54 (merge-base) diff File an issue against this benchmark runner |
|
🤖 Arrow criterion benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
- Add `snappy_cpp` feature flag that enables C++ snappy via snappy_src - Default `snap` feature uses pure-Rust snap crate (no C++ compiler needed) - Revert parquet-testing submodule to match master - Fix clippy uninit_vec warnings in C++ snappy codec Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
That 15-20% is pretty compelling |
Contributor
|
run benchmark arrow_reader_clickbench |
|
🤖 Arrow criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing snappy_cpp (226f5fb) to 9d0e8be (merge-base) diff File an issue against this benchmark runner |
|
Benchmark for this request failed. Last 20 lines of output: Click to expandFile an issue against this benchmark runner |
Contributor
Author
Somehow snappy_cpp seemed to be worse on the runner compared to rust, so it's mixed. I did some AI-guided optimization here BurntSushi/rust-snappy#64 which yielded ~30% improvements on the benchmarks (both locally and in runner) 🤯 |
|
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#9530
Use snappy_src (C++ snappy bindings) for raw snappy compress/decompress instead of the pure-Rust snap crate, while keeping snap as a dependency for CLI framed format support.
Getting some good perf numbers here.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?