Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions parquet/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,8 @@ experimental = ["variant_experimental"]
# Enable async APIs
async = ["futures", "tokio"]
# Enable object_store integration
# Deprecated: implement `AsyncFileReader` directly instead, see the example on
# the `AsyncFileReader` trait documentation and `parquet/examples/object_store.rs`.
# This feature will be removed in a future release.
# See https://github.com/apache/arrow-rs/issues/10308
object_store = ["dep:object_store", "async"]
# Group Zstd dependencies
zstd = ["dep:zstd"]
Expand Down
3 changes: 1 addition & 2 deletions parquet/examples/object_store.rs
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@ use std::ops::Range;
use std::sync::Arc;

/// This example demonstrates reading and writing Parquet files on object
/// storage via the [`object_store`] crate, without the deprecated
/// `ParquetObjectReader` and `ParquetObjectWriter` types.
/// storage via the [`object_store`] crate.
///
/// # Example Overview
///
Expand Down
4 changes: 2 additions & 2 deletions parquet/src/arrow/async_reader/store.rs
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ use tokio::runtime::Handle;
/// ```
#[deprecated(
since = "59.2.0",
note = "Implement `AsyncFileReader` directly instead; see the example on the `AsyncFileReader` trait documentation and `parquet/examples/object_store.rs`. Use `SpawnedReader` to perform I/O on a dedicated runtime."
note = "Implement `AsyncFileReader` directly instead; see the example on the `AsyncFileReader` trait documentation and `parquet/examples/object_store.rs`. Use `SpawnedReader` to perform I/O on a dedicated runtime. See https://github.com/apache/arrow-rs/issues/10308"
)]
#[derive(Clone, Debug)]
pub struct ParquetObjectReader {
Expand Down Expand Up @@ -140,7 +140,7 @@ impl ParquetObjectReader {
/// [here]: https://www.influxdata.com/blog/using-rustlangs-async-tokio-runtime-for-cpu-bound-tasks/
#[deprecated(
since = "59.2.0",
note = "Wrap the reader in a `SpawnedReader` instead, e.g. `SpawnedReader::new(reader, handle)`"
note = "Wrap the reader in a `SpawnedReader` instead, e.g. `SpawnedReader::new(reader, handle)`. See https://github.com/apache/arrow-rs/issues/10308"
)]
pub fn with_runtime(self, handle: Handle) -> Self {
Self {
Expand Down
2 changes: 1 addition & 1 deletion parquet/src/arrow/async_writer/store.rs
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ use tokio::io::AsyncWriteExt;
/// [`AsyncArrowWriter`]: crate::arrow::async_writer::AsyncArrowWriter
#[deprecated(
since = "59.2.0",
note = "Pass an `object_store::buffered::BufWriter` to `AsyncArrowWriter` directly instead; see `parquet/examples/object_store.rs`"
note = "Pass an `object_store::buffered::BufWriter` to `AsyncArrowWriter` directly instead; see https://github.com/apache/arrow-rs/issues/10308 and `parquet/examples/object_store.rs`."
)]
#[derive(Debug)]
pub struct ParquetObjectWriter {
Expand Down
Loading