arrow-avro: Deprecate object_store integration - #10484
Open
brancz wants to merge 1 commit into
Open
Conversation
Deprecate AvroObjectReader in favor of implementing AsyncFileReader directly (see the example on the trait docs and arrow-avro/examples/object_store.rs). To reduce the code needed by implementors I also added SpawnedReader. Still keeping object_store as a dev-dependency so we can ensure compatibility and use it in testing.
github-actions
Bot
added
arrow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecate AvroObjectReader in favor of implementing AsyncFileReader directly (see the example on the trait docs and
arrow-avro/examples/object_store.rs). To reduce the code needed by implementors I also added SpawnedReader. Still keeping object_store as a dev-dependency so we can ensure compatibility and use it in testing.
Which issue does this PR close?
Rationale for this change
See the issue
What changes are included in this PR?
Decoupling and removal of object_store dependencies in arrow-avro.
Are these changes tested?
Yes, see unit tests
Are there any user-facing changes?
No, but deprecation warnings that there will be.
@alamb