Enable allow_attributes lint for arrow-string - #10482
Open
Hashim1999164 wants to merge 3 commits into
Open
Conversation
Author
|
The x86_64 Linux Clippy failure is fixed by using target-specific |
Jefffrey
reviewed
Jul 30, 2026
| /// A binary based predicate | ||
| #[allow(clippy::large_enum_variant)] | ||
| #[cfg_attr( | ||
| all(target_os = "linux", target_arch = "x86_64"), |
Contributor
There was a problem hiding this comment.
i think its just x86_64; otherwise this will cause an issue on windows too if limited to only linux x86_64
Apply the expectation on all x86_64 targets, not only Linux, so Windows x86_64 gets the same Clippy handling.
Author
|
Updated the Clippy expectation to |
Hashim1999164
force-pushed
the
chore/enable-allow-attributes-lint
branch
from
July 31, 2026 18:57
98a95f2 to
70fb355
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #10458.
Rationale for this change
Enable
clippy::allow_attributesforarrow-stringso future lint suppressions use expectations and stale suppressions are detectable. The existinglarge_enum_variantsuppressions are still required on x86_64 Linux, so they are converted to target-specificexpectattributes instead of unconditionalallowattributes.What changes are included in this PR?
clippy::allow_attributesin thearrow-stringcrate.large_enum_variantsuppressions to lint expectations.Are there any user-facing changes?
No.
How was this change tested?
cargo +1.96.1 fmt --all -- --checkcargo +1.96.1 clippy -p arrow-string --all-targets --all-features -- -D warningscargo +1.96.1 clippy -p arrow-string --target x86_64-unknown-linux-gnu --all-targets --all-features -- -D warningscargo +1.96.1 test -p arrow-string --all-features(182 unit tests and 10 doc tests passed)AI assistance
AI assistance was used to identify the lint occurrences and draft the minimal edits. I reviewed the full diff and validated it with formatting, Clippy, and the crate's tests.