fix(arrow-json): validate map value nullability - #10475
Merged
Merged
Conversation
Jefffrey
approved these changes
Jul 29, 2026
Contributor
|
thanks @subotac |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
mapwith non-nullable value schema doesn't error if values are actually null #6391.Rationale for this change
The JSON map decoder constructed map entries with an unchecked
StructArrayconstructor. This bypassed child field nullability validation and allowed a null value even when the map value field was non-nullable.What changes are included in this PR?
StructArray::try_new_with_lengthso existing schema validation rejects unmasked nulls.Are these changes tested?
Yes:
cargo +stable fmt --all -- --checkcargo test -p arrow-json --all-featurescargo clippy --workspace --all-targets --all-features -- -D warningsgit diff --checkAre there any user-facing changes?
Yes. Reading a null JSON map value against a non-nullable value field now returns an error instead of producing an array that violates its schema. There are no public API changes.