Skip to content

Add versioned object_store feature flags #10454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tustvold wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add versioned object_store feature flags #10454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/arrow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,10 @@ jobs:
run: cargo test -p arrow-json --all-features
- name: Test arrow-avro
run: cargo test -p arrow-avro --all-features
# --all-features selects the newest supported object_store version, so test the
# older versions, which are gated behind their own feature flags, explicitly
- name: Test arrow-avro --features object_store
run: cargo test -p arrow-avro --features object_store
- name: Test arrow-string
run: cargo test -p arrow-string --all-features
- name: Test arrow-ord
Expand Down Expand Up @@ -172,6 +176,10 @@ jobs:
run: cargo check -p arrow --no-default-features --all-targets --features ffi
- name: Check compilation --no-default-features --all-targets --features chrono-tz
run: cargo check -p arrow --no-default-features --all-targets --features chrono-tz
# --all-features selects the newest supported object_store version, so check the
# older versions, which are gated behind their own feature flags, explicitly
- name: Check compilation arrow-avro --all-targets --features object_store
run: cargo check -p arrow-avro --all-targets --features object_store


# test the arrow crate builds against wasm32 in nightly rust
Expand Down
10 changes: 10 additions & 0 deletions .github/workflows/parquet.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,10 @@ jobs:
run: cargo test -p parquet
- name: Test --all-features
run: cargo test -p parquet --all-features
# --all-features selects the newest supported object_store version, so test the
# older versions, which are gated behind their own feature flags, explicitly
- name: Test --features object_store
run: cargo test -p parquet --features object_store
- name: Run examples
run: |
# Test parquet examples
Expand Down Expand Up @@ -124,6 +128,12 @@ jobs:
run: cargo check -p parquet --no-default-features --features flate2 --features flate2-zlib-rs
- name: Check compilation --no-default-features --features variant_experimental
run: cargo check -p parquet --no-default-features --features variant_experimental
# --all-features selects the newest supported object_store version, so check the
# older versions, which are gated behind their own feature flags, explicitly
- name: Check compilation --no-default-features --features object_store
run: cargo check -p parquet --no-default-features --features object_store
- name: Check compilation --all-targets --no-default-features --features arrow --features object_store
run: cargo check -p parquet --all-targets --no-default-features --features arrow --features object_store


# test the parquet crate builds against wasm32 in stable rust
Expand Down
242 changes: 237 additions & 5 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading