Test: add alignment test for arrow-flight - #10428
Merged
alamb merged 3 commits intoJul 28, 2026
Merged
Conversation
github-actions
Bot
added
arrow
Rich-T-kid
changed the title
Rich-T-kid
changed the title
Jefffrey
reviewed
Jul 26, 2026
| } | ||
|
|
||
| #[test] | ||
| #[should_panic( |
Contributor
There was a problem hiding this comment.
nit: we can probably assert on the error instead of relying on should_panic here (since we explicitly call unwrap in the helper)?
alamb
reviewed
Jul 28, 2026
alamb
left a comment
alamb
left a comment
Contributor
There was a problem hiding this comment.
This looks good other than the should_panic thing
Rich-T-kid
force-pushed
the
rich-t-kid/arrow-flight-decode-alignment-test
branch
from
July 28, 2026 15:03
c3f145b to
baac7e4
Compare
Rich-T-kid
commented
Jul 28, 2026
Rich-T-kid
left a comment
Rich-T-kid
left a comment
Contributor
Author
There was a problem hiding this comment.
should be good now
| } | ||
|
|
||
| #[test] | ||
| #[should_panic(expected = "Memory pointer is not aligned with the specified scalar type")] |
Contributor
Author
There was a problem hiding this comment.
The dense union panic originates inside arrow-buffer's ScalarBuffer code. Not from decode_misaligned's own unwrap()
Jefffrey
approved these changes
Jul 28, 2026
Contributor
|
Thanks @Rich-T-kid and @Jefffrey |
Jefffrey
added
the
development-process
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
see #10418
What changes are included in this PR?
Are these changes tested?
the changes are test
Are there any user-facing changes?
no