Skip to content

chore: fix failing miri test - #10415

Closed
Jefffrey wants to merge 2 commits into
apache:mainfrom
Jefffrey:fix-miri
Closed

chore: fix failing miri test#10415
Jefffrey wants to merge 2 commits into
apache:mainfrom
Jefffrey:fix-miri

Conversation

@Jefffrey

Copy link
Copy Markdown
Contributor

miri failing on main and on PRs:

running 1 test
    test datatype_parse::test::parse_data_type_errors ... Parsing '', expecting 'Unsupported type '''
    Parsing '', expecting 'Error finding next token'
    Parsing 'null', expecting 'Unsupported type 'null''
    Parsing 'Nu', expecting 'Unsupported type 'Nu''
    Parsing 'Timestamp(ns, +00:00)', expecting 'Error unknown token: +00'
    Parsing 'Timestamp(ns, "+00:00)', expecting 'Unterminated string at: "+00:00)'
    Parsing 'Timestamp(ns, "")', expecting 'empty strings aren't allowed'
    Parsing 'Timestamp(ns, "+00:00"")', expecting 'Parser error: Unterminated string at: ")'
    Parsing 'Timestamp(ns, ', expecting 'Error finding next token'
    Parsing 'Float32 Float32', expecting 'trailing content after parsing 'Float32''
    Parsing 'Int32, ', expecting 'trailing content after parsing 'Int32''
    Parsing 'Int32(3), ', expecting 'trailing content after parsing 'Int32''
    Parsing 'FixedSizeBinary(Int32), ', expecting 'Error finding i64 for FixedSizeBinary, got 'Int32''
    Parsing 'FixedSizeBinary(3.0), ', expecting 'Error parsing 3.0 as integer: invalid digit found in string'
    Parsing 'FixedSizeBinary(4000000000), ', expecting 'Error converting 4000000000 into i32 for FixedSizeBinary: out of range integral type conversion attempted'
    FAILED

    failures:

    failures:
        datatype_parse::test::parse_data_type_errors

    test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 99 filtered out; finished in 8.15s

  stderr ───

    thread 'datatype_parse::test::parse_data_type_errors' (12098) panicked at arrow-schema/src/datatype_parse.rs:1618:21:


    did not find expected in actual.

    expected: Error converting 4000000000 into i32 for FixedSizeBinary: out of range integral type conversion attempted
    actual: Parser error: Unsupported type 'FixedSizeBinary(4000000000), '. Must be a supported arrow type name such as 'Int32' or 'Timestamp(ns)'. Error converting 4000000000 into i32 for FixedSizeBinary: number too large to fit in target type

i dunno why miri gives us a different error message, but oh well

@github-actions github-actions Bot added the arrow Changes to the arrow crate label Jul 23, 2026

@Phoenix500526 Phoenix500526 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alamb

alamb commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Soryr -- looks like I missed htis one and merged an alternate fix from @bit2swaz instead

@alamb

alamb commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

The good news is the fix was the same, so I will close this PR

Thank you @Jefffrey and @Phoenix500526

@alamb alamb closed this Jul 25, 2026
@Jefffrey
Jefffrey deleted the fix-miri branch July 25, 2026 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants