Fix Flight LargeList schema encoding - #10298
Draft
yinli-systems wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
LargeListin Flight data encoder #10291.Rationale for this change
prepare_field_for_flightrebuildsDataType::LargeListwithField::new_list, silently changing the 64-bit offset type into a regularListin the Flight schema. The adjacentListView/LargeListViewpath already preserves its large variant.What changes are included in this PR?
Field::new_large_listforDataType::LargeList.FlightDataEncodertoFlightDataDecoderIPC round trip covering List, nested LargeList<List>, FixedSizeList, parent and child nullability, and schema/field/child metadata.Are these changes tested?
Yes, locally with Rust 1.96.1 on macOS:
new_listimplementation: the round-trip regression test fails because decodedLargeListbecomesList.cargo test -p arrow-flight test_list_schema_round_tripcargo test -p arrow-flight --lib(42 passed)cargo test -p arrow-flight(unit, client, encode/decode, and doc tests passed)cargo clippy -p arrow-flight --all-targets --all-features -- -D warningscargo fmt --all -- --checkgit diff --checkI used AI assistance to inspect the nearby Flight schema-preparation paths and help generate the focused round-trip regression, then reviewed the resulting one-line production fix and validated it with the commands above.
Are there any user-facing changes?
Yes. Flight-encoded schemas now preserve
LargeListinstead of exposing it asListafter schema preparation.