Avoid over-reserving Vecs in compression codecs

[MassivePizza]

Which issue does this PR close?

• Closes Parquet: Should DataPageV2 shrink_to_fit? #10448.

This is a continuation to PR #10345.

Rationale for this change

The Vecs that we over-reserved can be long-lived, see issue above.

What changes are included in this PR?

Use zstd_safe contexts directly to compress/decompress, allowing us to append to Vec without reserving excessive amounts.

Remove redundant loops in LZ4Codec.

Are these changes tested?

Should be covered by existing tests.

One thing I felt while looking was the lack of tests regarding compression frames (some codecs look like they may decompress too much or not enough). Could add tests for that if desired.

Are there any user-facing changes?

No.

[Jefffrey]

run benchmark compression

[adriangbot]

🤖 Arrow criterion benchmark completed (GKE) | trigger

Instance: c4a-highmem-16 (12 vCPU / 65 GiB)

CPU Details (lscpu)

Architecture:                            aarch64
CPU op-mode(s):                          64-bit
Byte Order:                              Little Endian
CPU(s):                                  16
On-line CPU(s) list:                     0-15
Vendor ID:                               ARM
Model name:                              Neoverse-V2
Model:                                   1
Thread(s) per core:                      1
Core(s) per cluster:                     16
Socket(s):                               -
Cluster(s):                              1
Stepping:                                r0p1
BogoMIPS:                                2000.00
Flags:                                   fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache:                               1 MiB (16 instances)
L1i cache:                               1 MiB (16 instances)
L2 cache:                                32 MiB (16 instances)
L3 cache:                                80 MiB (1 instance)
NUMA node(s):                            1
NUMA node0 CPU(s):                       0-15
Vulnerability Gather data sampling:      Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit:             Not affected
Vulnerability L1tf:                      Not affected
Vulnerability Mds:                       Not affected
Vulnerability Meltdown:                  Not affected
Vulnerability Mmio stale data:           Not affected
Vulnerability Reg file data sampling:    Not affected
Vulnerability Retbleed:                  Not affected
Vulnerability Spec rstack overflow:      Not affected
Vulnerability Spec store bypass:         Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:                Mitigation; __user pointer sanitization
Vulnerability Spectre v2:                Mitigation; CSV2, BHB
Vulnerability Srbds:                     Not affected
Vulnerability Tsa:                       Not affected
Vulnerability Tsx async abort:           Not affected
Vulnerability Vmscape:                   Not affected

Details

group                                               compress-reserve-begone                main
-----                                               -----------------------                ----
compress BROTLI(BrotliLevel(1)) - alphanumeric      1.00      4.2±0.01ms        ? ?/sec    1.00      4.2±0.03ms        ? ?/sec
compress BROTLI(BrotliLevel(1)) - words             1.00      5.3±0.02ms        ? ?/sec    1.00      5.2±0.00ms        ? ?/sec
compress GZIP(GzipLevel(6)) - alphanumeric          1.00     20.7±0.09ms        ? ?/sec    1.00     20.8±0.13ms        ? ?/sec
compress GZIP(GzipLevel(6)) - words                 1.00     26.1±0.06ms        ? ?/sec    1.00     26.1±0.03ms        ? ?/sec
compress LZ4 - alphanumeric                         1.00     39.5±0.40µs        ? ?/sec    1.03     40.7±0.26µs        ? ?/sec
compress LZ4 - words                                1.00   1807.5±1.40µs        ? ?/sec    1.00   1807.8±1.70µs        ? ?/sec
compress LZ4_RAW - alphanumeric                     1.00     38.9±0.47µs        ? ?/sec    1.04     40.4±0.22µs        ? ?/sec
compress LZ4_RAW - words                            1.00   1808.3±3.40µs        ? ?/sec    1.00   1807.6±1.36µs        ? ?/sec
compress SNAPPY - alphanumeric                      1.02     34.1±0.47µs        ? ?/sec    1.00     33.4±0.12µs        ? ?/sec
compress SNAPPY - words                             1.00   1459.3±3.19µs        ? ?/sec    1.00   1459.2±1.19µs        ? ?/sec
compress ZSTD(ZstdLevel(1)) - alphanumeric          1.03    953.8±1.83µs        ? ?/sec    1.00    923.2±0.50µs        ? ?/sec
compress ZSTD(ZstdLevel(1)) - words                 1.05      2.8±0.01ms        ? ?/sec    1.00      2.7±0.01ms        ? ?/sec
decompress BROTLI(BrotliLevel(1)) - alphanumeric    1.00      7.3±0.01ms        ? ?/sec    1.00      7.3±0.03ms        ? ?/sec
decompress BROTLI(BrotliLevel(1)) - words           1.01      3.3±0.01ms        ? ?/sec    1.00      3.2±0.01ms        ? ?/sec
decompress GZIP(GzipLevel(6)) - alphanumeric        1.00      2.8±0.00ms        ? ?/sec    1.01      2.8±0.01ms        ? ?/sec
decompress GZIP(GzipLevel(6)) - words               1.00    969.3±6.56µs        ? ?/sec    1.03   1000.0±7.59µs        ? ?/sec
decompress LZ4 - alphanumeric                       1.00     37.1±0.09µs        ? ?/sec    1.04     38.6±1.09µs        ? ?/sec
decompress LZ4 - words                              1.00    327.4±0.63µs        ? ?/sec    1.01    332.1±0.30µs        ? ?/sec
decompress LZ4_RAW - alphanumeric                   1.00     37.1±0.08µs        ? ?/sec    1.03     38.2±0.26µs        ? ?/sec
decompress LZ4_RAW - words                          1.00    327.3±0.23µs        ? ?/sec    1.01    330.5±0.27µs        ? ?/sec
decompress SNAPPY - alphanumeric                    1.01     26.9±0.37µs        ? ?/sec    1.00     26.7±0.36µs        ? ?/sec
decompress SNAPPY - words                           1.00    580.8±0.86µs        ? ?/sec    1.00    580.8±0.85µs        ? ?/sec
decompress ZSTD(ZstdLevel(1)) - alphanumeric        1.04   1048.4±3.54µs        ? ?/sec    1.00   1003.9±0.82µs        ? ?/sec
decompress ZSTD(ZstdLevel(1)) - words               1.03   1014.0±1.13µs        ? ?/sec    1.00    979.9±0.92µs        ? ?/sec

Resource Usage

base (merge-base)

Metric	Value
Wall time	305.1s
Peak memory	14.6 MiB
Avg memory	12.7 MiB
CPU user	297.8s
CPU sys	1.2s
Peak spill	0 B

branch

Metric	Value
Wall time	310.1s
Peak memory	14.8 MiB
Avg memory	13.0 MiB
CPU user	305.2s
CPU sys	1.2s
Peak spill	0 B

---

File an issue against this benchmark runner

[mapleFU]

Emmm calling reserve_exact in a loop is a bit weird, does this guranteed calling once?