feat(c/driver/sqlite): ensure batch rows option can be retrieved - #4645
Open
lidavidm wants to merge 2 commits into
Open
feat(c/driver/sqlite): ensure batch rows option can be retrieved#4645lidavidm wants to merge 2 commits into
lidavidm wants to merge 2 commits into
Conversation
The getter existed, but the framework needed to be extended to also allow fetching it as a string, and tests were added. Closes apache#3456. Assisted-by: GPT-5.6 Sol <codex@openai.com>
paleolimbot
approved these changes
Aug 4, 2026
Comment on lines
+178
to
+179
| formatted = std::to_string(value); | ||
| string_value = formatted; |
Member
There was a problem hiding this comment.
Are there any locale concerns here (i.e., doubles getting exported as 123,456 instead of 123.456)? to_chars() might be better (although I think there was a thing where some gcc versions don't include it?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The getter existed, but the framework needed to be extended to also allow fetching it as a string, and tests were added.
Closes #3456.
Assisted-by: GPT-5.6 Sol codex@openai.com