-
Notifications
You must be signed in to change notification settings - Fork 208
feat(javascript): publish a win32-arm64 native package #4634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -91,6 +91,8 @@ jobs: | |
| target: aarch64-apple-darwin | ||
| - host: windows-latest | ||
| target: x86_64-pc-windows-msvc | ||
| - host: windows-11-arm | ||
| target: aarch64-pc-windows-msvc | ||
| - host: ubuntu-latest | ||
| target: x86_64-unknown-linux-gnu | ||
| - host: ubuntu-24.04-arm | ||
|
|
@@ -149,6 +151,8 @@ jobs: | |
| target: aarch64-apple-darwin | ||
| - host: windows-latest | ||
| target: x86_64-pc-windows-msvc | ||
| - host: windows-11-arm | ||
| target: aarch64-pc-windows-msvc | ||
| steps: | ||
| - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
| with: | ||
|
|
@@ -169,18 +173,40 @@ jobs: | |
| name: bindings-${{ matrix.settings.target }} | ||
| path: javascript | ||
| - name: Setup conda (Windows) | ||
| if: runner.os == 'Windows' | ||
| # Miniforge does not publish a Windows ARM64 installer, so the ARM64 | ||
| # leg uses micromamba (which ships native arm64 binaries) below. | ||
| if: runner.os == 'Windows' && runner.arch != 'ARM64' | ||
| uses: conda-incubator/setup-miniconda@8ee1f361103df19b6f8c8655fd3967a8ecb162d5 # v4.0.1 | ||
|
Comment on lines
175
to
179
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. With the micromamba rework, |
||
| with: | ||
| miniforge-version: latest | ||
| - name: Install C++ dependencies (Windows) | ||
| if: runner.os == 'Windows' | ||
| if: runner.os == 'Windows' && runner.arch != 'ARM64' | ||
| run: conda install -c conda-forge --file ci/conda_env_cpp.txt | ||
|
Comment on lines
+183
to
184
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As @eitsupi points out if we can use setup-micromamba and stay consistent that would be ideal.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done — the win-arm64 test leg now uses the conda-forge flow via micromamba
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't really want to work around the allowlist...we should get it added. |
||
| - name: Install C++ dependencies (Windows ARM64) | ||
| # mamba-org/setup-micromamba is not on the ASF actions allowlist, so | ||
| # fetch the official micromamba binary directly (pinned + checksummed). | ||
| # conda-forge's win-arm64 platform does not have cmake, compilers, | ||
| # libpq, or pkg-config yet, so install just what the SQLite driver | ||
| # build needs and use the runner's preinstalled MSVC and CMake. | ||
| # CONDA_PREFIX is exported so the shared "Set driver path (Windows)" | ||
| # step puts the env's Library\bin (sqlite3.dll) on PATH. | ||
| if: runner.os == 'Windows' && runner.arch == 'ARM64' | ||
| shell: pwsh | ||
| run: | | ||
| $version = "2.8.1-0" | ||
| $sha256 = "c90eda5e4c88ebd4fb4c857d7c98d7484156fae5419b72c9c652f331ad7aad9f" | ||
| $exe = "$env:RUNNER_TEMP\micromamba.exe" | ||
| Invoke-WebRequest -Uri "https://github.com/mamba-org/micromamba-releases/releases/download/$version/micromamba-win-arm64.exe" -OutFile $exe | ||
| if ((Get-FileHash $exe -Algorithm SHA256).Hash -ne $sha256) { throw "micromamba checksum mismatch" } | ||
| $prefix = "$env:RUNNER_TEMP\conda-env" | ||
| & $exe create --yes --prefix $prefix --channel conda-forge libsqlite | ||
| echo "CONDA_PREFIX=$prefix" >> $env:GITHUB_ENV | ||
| echo "ADBC_CMAKE_ARGS=-DCMAKE_PREFIX_PATH=$($prefix -replace '\\','/')/Library" >> $env:GITHUB_ENV | ||
| - name: Install C++ dependencies (Linux) | ||
| if: runner.os == 'Linux' | ||
| run: sudo apt-get install libsqlite3-dev | ||
| - name: Set cmake args (Windows) | ||
| if: runner.os == 'Windows' | ||
| if: runner.os == 'Windows' && runner.arch != 'ARM64' | ||
| shell: pwsh | ||
| run: echo "ADBC_CMAKE_ARGS=-DCMAKE_PREFIX_PATH=$env:CONDA_PREFIX/Library" >> $env:GITHUB_ENV | ||
| - name: Build Driver | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| <!--- | ||
| Licensed to the Apache Software Foundation (ASF) under one | ||
| or more contributor license agreements. See the NOTICE file | ||
| distributed with this work for additional information | ||
| regarding copyright ownership. The ASF licenses this file | ||
| to you under the Apache License, Version 2.0 (the | ||
| "License"); you may not use this file except in compliance | ||
| with the License. You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, | ||
| software distributed under the License is distributed on an | ||
| "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| KIND, either express or implied. See the License for the | ||
| specific language governing permissions and limitations | ||
| under the License. | ||
| --> | ||
|
|
||
| # `adbc-driver-manager-win32-arm64-msvc` | ||
|
|
||
| This is the **aarch64-pc-windows-msvc** binary for `adbc-driver-manager` |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| { | ||
| "name": "@apache-arrow/adbc-driver-manager-win32-arm64-msvc", | ||
| "version": "0.25.0", | ||
| "cpu": [ | ||
| "arm64" | ||
| ], | ||
| "main": "adbc-driver-manager.win32-arm64-msvc.node", | ||
| "files": [ | ||
| "adbc-driver-manager.win32-arm64-msvc.node" | ||
| ], | ||
| "description": "Node.js ADBC Driver Manager", | ||
| "license": "Apache-2.0", | ||
| "engines": { | ||
| "node": ">=22.0.0" | ||
| }, | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "git+https://github.com/apache/arrow-adbc.git", | ||
| "directory": "javascript" | ||
| }, | ||
| "os": [ | ||
| "win32" | ||
| ] | ||
| } |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
This comment was marked as resolved.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as resolved.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.