feat(dev/release): verify binary JARs on Windows - #4624
Merged
Conversation
Member
Author
|
That said, even with LLMs, I'm still tempted to declare that verification will require Python and just unify the verification scripts across platforms rather than maintain both PowerShell and Bash versions. |
Member
Author
|
I'll fix this separately. #4639 |
amoeba
approved these changes
Aug 3, 2026
amoeba
left a comment
Member
There was a problem hiding this comment.
I'm supportive of having a single bash script for all paltforms. The deps we need on Windows are pretty easy to acquire.
- Add a skeleton for binary verification - Add options (like the Unix script) to control what to verify - Add Java JAR verification by testing a minimal Maven project On a Windows VM I've used the 24 RC1 artifacts (which are still present) to validate that the test fails as expected. Part of apache#4583. Assisted-by: GPT 5.6 Sol <codex@openai.com>
Co-authored-by: Bryce Mecum <petridish@gmail.com>
Co-authored-by: Bryce Mecum <petridish@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a Windows VM I've used the 24 RC1 artifacts (which are still
present) to validate that the test fails as expected.
This is intentionally minimal. It can be extended for other
platforms and binaries next.
Part of #682.
Part of #4583.
Assisted-by: GPT 5.6 Sol codex@openai.com