Skip to content

feat(dev/release): verify binary JARs on Windows - #4624

Merged
lidavidm merged 4 commits into
apache:mainfrom
lidavidm:gh-4583
Aug 4, 2026
Merged

feat(dev/release): verify binary JARs on Windows#4624
lidavidm merged 4 commits into
apache:mainfrom
lidavidm:gh-4583

Conversation

@lidavidm

@lidavidm lidavidm commented Jul 29, 2026

Copy link
Copy Markdown
Member
  • Add a skeleton for binary verification
  • Add options (like the Unix script) to control what to verify
  • Add Java JAR verification by testing a minimal Maven project

On a Windows VM I've used the 24 RC1 artifacts (which are still
present) to validate that the test fails as expected.

This is intentionally minimal. It can be extended for other
platforms and binaries next.

Part of #682.
Part of #4583.

Assisted-by: GPT 5.6 Sol codex@openai.com

@lidavidm

Copy link
Copy Markdown
Member Author

That said, even with LLMs, I'm still tempted to declare that verification will require Python and just unify the verification scripts across platforms rather than maintain both PowerShell and Bash versions.

@lidavidm

lidavidm commented Jul 31, 2026

Copy link
Copy Markdown
Member Author

I'll fix this separately. #4639

> if (!requireNamespace("testthat", quietly = TRUE)) install.packages("testthat", repos = "https://cloud.r-project.org/")
> 
+ R CMD INSTALL /tmp/arrow-adbc-1.13.0.Zr0E8/apache-arrow-adbc-1.13.0/r/adbcdrivermanager --preclean --library=/tmp/arrow-adbc-1.13.0.Zr0E8/r/tmplib
* installing *source* package ‘adbcdrivermanager’ ...
** this is package ‘adbcdrivermanager’ version ‘0.24.0.9000’
** using staged installation
Running bootstrap.R...
** libs
Error: C++20 standard requested but CXX20 is not defined
* removing ‘/tmp/arrow-adbc-1.13.0.Zr0E8/r/tmplib/adbcdrivermanager’
+ cleanup
+ chmod -R u+w /tmp/arrow-adbc-1.13.0.Zr0E8
+ '[' no = yes ']'
Failed to verify release candidate. See /tmp/arrow-adbc-1.13.0.Zr0E8 for details.
+ echo 'Failed to verify release candidate. See /tmp/arrow-adbc-1.13.0.Zr0E8 for details.'

@amoeba amoeba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm supportive of having a single bash script for all paltforms. The deps we need on Windows are pretty easy to acquire.

Comment thread dev/release/verify-release-candidate.ps1 Outdated
Comment thread dev/release/verify-release-candidate.ps1
lidavidm and others added 4 commits August 4, 2026 10:27
- Add a skeleton for binary verification
- Add options (like the Unix script) to control what to verify
- Add Java JAR verification by testing a minimal Maven project

On a Windows VM I've used the 24 RC1 artifacts (which are still
present) to validate that the test fails as expected.

Part of apache#4583.

Assisted-by: GPT 5.6 Sol <codex@openai.com>
Co-authored-by: Bryce Mecum <petridish@gmail.com>
Co-authored-by: Bryce Mecum <petridish@gmail.com>
@lidavidm
lidavidm merged commit f12adc3 into apache:main Aug 4, 2026
11 of 12 checks passed
@lidavidm
lidavidm deleted the gh-4583 branch August 4, 2026 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants