Skip to content

[ARIES-2159] fix NPE when DatabaseMetaData wants to get connection from DummyDataSource#16

Open
jherkel wants to merge 1 commit into
apache:masterfrom
jherkel:master
Open

[ARIES-2159] fix NPE when DatabaseMetaData wants to get connection from DummyDataSource#16
jherkel wants to merge 1 commit into
apache:masterfrom
jherkel:master

Conversation

@jherkel

@jherkel jherkel commented Oct 30, 2024

Copy link
Copy Markdown

@glimmerveen

Copy link
Copy Markdown

Hi @jbonofre , would you be able to look into this PR?

@jbonofre

Copy link
Copy Markdown
Member

@glimmerveen it's on my todo not yet started.

@glimmerveen

Copy link
Copy Markdown

Hi @jbonofre , any update on this?

@alien11689

Copy link
Copy Markdown
Contributor

Hi @jherkel @glimmerveen
could you provide a test covering newly added code?
It could be a quite simple test just calling getConnection().getCatalog() ensuring that the NPE is not thrown.

@jherkel

jherkel commented Jun 18, 2025

Copy link
Copy Markdown
Author

@alien11689 I have added a simple unit test.

@alien11689 alien11689 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jbonofre would you like to take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants