Skip to content

IVY-1204, IVY-1585: if dependency is rejected, reject parent revision and restart#125

Open
eric-milles wants to merge 1 commit into
apache:masterfrom
eric-milles:IVY-1204
Open

IVY-1204, IVY-1585: if dependency is rejected, reject parent revision and restart#125
eric-milles wants to merge 1 commit into
apache:masterfrom
eric-milles:IVY-1204

Conversation

@eric-milles

Copy link
Copy Markdown
Member

This should also close IVY-1228 in my estimation. After blacklisting B;2.2 and A;1.1, the dynamic revision B;[0.0,) resolves to B;2.1 next. That node has dependency A;1.1. The usual logic is to find or make an IvyNode for this mrid. ResolveData retains such an IvyNode to hold eviction data. This eviction data is not checked and A;1.1 was already downloaded previously, so normal conflict resolve does not catch this.

I tried a few different things, but the most straightforward thing to do seemed to be check for blacklisting of dependency revision. If so listed, propagate the blacklisting to the requesting node -- B;2.1 in this case.

If instead I fed A;1.0 and A;1.1 into the conflict manager at this location, it throws StrictConflictException.

@eric-milles

Copy link
Copy Markdown
Member Author

@maartenc okay?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant