add checks for online status before expecting resources available#121
Open
eric-milles wants to merge 1 commit into
Open
add checks for online status before expecting resources available#121eric-milles wants to merge 1 commit into
eric-milles wants to merge 1 commit into
Conversation
Member
Author
|
@maartenc Any issues with this? |
Contributor
|
I would prefer that you'd somehow pass some extra option, or use a different Ant target, to run the tests in offline mode. Also here, this can be done after a 2.6.0 release |
eric-milles
force-pushed
the
offline-testing
branch
from
24bcdd8 to
2cfd35c
Compare
Member
Author
|
I could add tags if it was JUnit 5. But I did not want to tilt at that particular windmill just yet. Not sure if JUnit 4 category is usable enough. Anyways, there are some assumes used before I added, so there is a wider bit of work to try and mark all the offline-incompatible tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a short outage and noticed that quite a few tests expect online connectivity but not all have assumes to skip if offline.