Validate GCSToLocalFilesystemOperator arguments after template rendering - #70489
Closed
mitre88 wants to merge 1 commit into
Closed
Validate GCSToLocalFilesystemOperator arguments after template rendering#70489mitre88 wants to merge 1 commit into
mitre88 wants to merge 1 commit into
Conversation
filename and store_to_xcom_key are template fields, but their mutual-exclusion check ran in __init__, before Jinja rendering — templated values were rejected at Dag parse time based on the raw expressions. Validate in execute() instead.
mitre88
requested review from
amoghrajesh,
ashb,
bugraoz93,
gopidesupavan,
jason810496,
jscheffl,
potiuk and
shahar1
as code owners
July 27, 2026 00:28
boring-cyborg
Bot
added
area:dev-tools
area:providers
backport-to-v3-3-test
uranusjr
approved these changes
Jul 27, 2026
Contributor
|
Closing as false positive according to the up-to-date definition, see details here: |
Contributor
Author
|
Thanks — that matches the relaxed definition in #70505 (provision checks belong in Drafted-by: Claude Code (Fable 5) (no human review before posting) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
filenameandstore_to_xcom_keyare template fields ofGCSToLocalFilesystemOperator, but the "only one can be set" check ran in__init__, before Jinja rendering — so templated values were judged on their raw expressions at Dag parse time. The check now runs at the top ofexecute()on rendered values, with a test asserting the failure at execute time. Removes the class from the exemption list.related: #70296
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Fable 5) following the guidelines