Skip to content

Move BashOperator template field logic from __init__ to execute #70429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kunal8954 wants to merge 3 commits into
base: main
Choose a base branch
from
+5 −6
Open

Move BashOperator template field logic from __init__ to execute #70429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a28a154
Move BashOperator template field logic from __init__ to execute
Jul 25, 2026
acc41a4
Remove BashOperator from validate-operators-init exemption list
Jul 25, 2026
2046f37
Fix formatting: remove trailing whitespace on blank line
Jul 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions providers/standard/src/airflow/providers/standard/operators/bash.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,10 +178,6 @@ def __init__(
self.cwd = cwd
self.append_env = append_env
self.output_processor = output_processor
self._is_inline_cmd = None
if isinstance(bash_command, str):
self._is_inline_cmd = self._is_inline_command(bash_command=bash_command)

@cached_property
def subprocess_hook(self):
"""Returns hook for running the bash command."""
Expand Down Expand Up @@ -215,7 +211,11 @@ def execute(self, context: Context):
raise AirflowException(f"The cwd {self.cwd} must be a directory")
env = self.get_env(context)

if self._is_inline_cmd:
is_inline_cmd = isinstance(self.bash_command, str) and self._is_inline_command(
bash_command=self.bash_command
)

if is_inline_cmd:
result = self._run_inline_command(bash_path=bash_path, env=env)
else:
result = self._run_rendered_script_file(bash_path=bash_path, env=env)
Expand Down
1 change: 0 additions & 1 deletion scripts/ci/prek/validate_operators_init_exemptions.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,5 @@ providers/microsoft/azure/src/airflow/providers/microsoft/azure/transfers/oracle
providers/microsoft/psrp/src/airflow/providers/microsoft/psrp/operators/psrp.py::PsrpOperator
providers/oracle/src/airflow/providers/oracle/transfers/oracle_to_oracle.py::OracleToOracleOperator
providers/papermill/src/airflow/providers/papermill/operators/papermill.py::PapermillOperator
providers/standard/src/airflow/providers/standard/operators/bash.py::BashOperator
providers/standard/src/airflow/providers/standard/operators/trigger_dagrun.py::TriggerDagRunOperator
providers/standard/src/airflow/providers/standard/sensors/date_time.py::DateTimeSensor
Loading