Skip to content

UI: Hide run-on-latest-version option for non-versioned bundles #70427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WonYong-Jang wants to merge 2 commits into
base: main
Choose a base branch
from
+14 −11
Open

UI: Hide run-on-latest-version option for non-versioned bundles #70427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50565b6
UI: Hide "run with latest bundle version" clear option for non-versio…
WonYong-Jang Jul 25, 2026
60f43c0
Merge branch 'main' into hide-run-on-latest-for-non-versioned-bundles
WonYong-Jang Jul 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions airflow-core/src/airflow/ui/src/components/Clear/Run/ClearRunDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import { CgRedo } from "react-icons/cg";
import { useDagServiceGetDagDetails } from "openapi/queries";
import type { DAGRunResponse } from "openapi/requests/types.gen";
import { ActionAccordion } from "src/components/ActionAccordion";
import { getRunOnLatestVersionState } from "src/components/Clear/TaskInstance/runOnLatestVersion";
import { useRerunWithLatestVersion } from "src/components/Clear/useRerunWithLatestVersion";
import { Checkbox, Dialog } from "src/components/ui";
import SegmentedControl from "src/components/ui/SegmentedControl";
Expand Down Expand Up @@ -91,14 +92,16 @@ const ClearRunDialog = ({ dagRun, onClose, open }: Props) => {
onSuccessConfirm: handleClose,
});

// Check if DAG versions differ (works for both bundle-versioned and local bundles)
const latestDagVersionNumber = dagDetails?.latest_dag_version?.version_number;
const dagRunVersionNumber = dagRun.dag_versions.at(-1)?.version_number;
const versionsDiffer =
latestDagVersionNumber !== undefined &&
dagRunVersionNumber !== undefined &&
latestDagVersionNumber !== dagRunVersionNumber;
const shouldShowBundleVersionOption = versionsDiffer && !onlyNew;
// Non-versioned bundles (e.g. LocalDagBundle) always leave bundle_version null and
// resolve to the latest serialized Dag at run time, so "run on latest" is a no-op there.
// Only offer it when the run is pinned to an older bundle version, where it actually changes the outcome.
const { shouldShowRunOnLatestOption } = getRunOnLatestVersionState({
latestBundleVersion: dagDetails?.bundle_version,
latestDagVersionNumber: dagDetails?.latest_dag_version?.version_number,
selectedBundleVersion: dagRun.dag_versions.at(-1)?.bundle_version,
selectedDagVersionNumber: dagRun.dag_versions.at(-1)?.version_number,
});
const shouldShowBundleVersionOption = shouldShowRunOnLatestOption && !onlyNew;

return (
<Dialog.Root
Expand Down
4 changes: 2 additions & 2 deletions airflow-core/src/airflow/ui/src/components/Clear/TaskInstance/runOnLatestVersion.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ describe("getRunOnLatestVersionState", () => {
it.each([
{
expectedDagVersionsDiffer: true,
expectedShouldShowRunOnLatestOption: true,
expectedShouldShowRunOnLatestOption: false,
latestDagVersionNumber: 3,
name: "shows and defaults on when DAG version numbers differ",
name: "does not show when DAG versions differ but no bundle version is present (non-versioned bundle)",
selectedDagVersionNumber: 2,
},
{
Expand Down
2 changes: 1 addition & 1 deletion airflow-core/src/airflow/ui/src/components/Clear/TaskInstance/runOnLatestVersion.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,6 @@ export const getRunOnLatestVersionState = ({

return {
dagVersionsDiffer,
shouldShowRunOnLatestOption: dagVersionsDiffer || shouldShowForBundleVersion,
shouldShowRunOnLatestOption: shouldShowForBundleVersion,
};
};